Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong display of letters with marks above (ščžáé...) - on the map #5006

Closed
CTJoriginal opened this issue May 8, 2023 · 16 comments
Closed
Labels
bug feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@CTJoriginal
Copy link
Contributor

Street Complete displays text of letters with marks (čšžćá...) wrongly; instead of mark being above the letter it gets moved to right where it intercepts with next letter in line (check attached screenshots), which makes text verry hard to read. Issue only happens on text displayed on the map and not in input fields.

SmartSelect_20230508_101441_StreetComplete.jpg

SmartSelect_20230508_100930_StreetComplete.jpg

How to Reproduce
Create place (shop overlay) with name, that contains these letters

Expected Behavior
It's expected that these letters appear like this: ščžćáè...

Versions affected
Android: 13, ONE UI 5.1
App: v51.2

@CTJoriginal CTJoriginal added the bug label May 8, 2023
@CTJoriginal CTJoriginal changed the title Wrong display of letters with marks above Wrong display of letters with marks above (ščžáé...) May 8, 2023
@Helium314
Copy link
Collaborator

Do the names display correctly when you open the element?
If yes, it might be related to #4554 (which can't be fixed in SC)

@matkoniecz matkoniecz changed the title Wrong display of letters with marks above (ščžáé...) Wrong display of letters with marks above (ščžáé...) on the map May 8, 2023
@matkoniecz matkoniecz changed the title Wrong display of letters with marks above (ščžáé...) on the map Wrong display of letters with marks above (ščžáé...) - on the map May 8, 2023
@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label May 8, 2023
@mnalis
Copy link
Member

mnalis commented May 8, 2023

Yes, it would be interesting to know:

  • what language is chosen in StreetComplete?
  • at what location is that happening?

For me (SC v52.1, EMUI 12/Android 10?) with Croatian language, it works (and has always worked) just fine, e.g. at https://www.openstreetmap.org/way/591540390:

small_SVID_20230508_215508_1.mp4

@Helium314
Copy link
Collaborator

Looks fine for me too (Android 9)
Could be that it's broken on Android 12+ only? There were some font issues previously: tangrams/tangram-es#2303

@CTJoriginal
Copy link
Contributor Author

It seems to happen in all languages for me
https://user-images.githubusercontent.com/48687492/237055928-65774bb9-8a08-4a12-a3fa-27bb2b8e11bf.mp4

I have attempted reinstalling app and issue persists.

@Helium314 yes names display correctly when you open element

@mnalis It's happening in Slovenia

@matkoniecz
Copy link
Member

Is it happening also with Polish letters? Such as Ś and ó?

https://www.openstreetmap.org/node/3009775614

https://www.openstreetmap.org/relation/2432115#map=15/50.1474/21.9713

@CTJoriginal
Copy link
Contributor Author

I went ahead and tried all accents:

SmartSelect_20230509_121334_StreetComplete.jpg

I also found out that names dont even display if they contain letters such as "ș ş" and any zalgo text (T̴̜͉̈́͐e̶̝̮̒ş̴̱̐̓t̵̙̐ ̴͔̹̍1̸̼̣̓2̷̳̞͛3̵̫̂). I guess it can't display text if it has marks bellow letter.

@westnordost
Copy link
Member

Right, anyway, the fact that it only happens for things rendered on the map but not in the UI means that it is a tangram-es issue and we can do nothing about this. So I'll close this as will-not-fix, as it is an upstream issue.

Unfortunately, tangram-es isn't really maintained anymore. I figure, you could post an issue there, but most probably it would just be for documentation purposes. It may also be just the same issue as tangrams/tangram-es#2335, so you could also just add a comment there.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2023
@CTJoriginal
Copy link
Contributor Author

Alright, I guess we will just have to live with it then.

@mnalis
Copy link
Member

mnalis commented May 9, 2023

@CTJoriginal you can try testing with testing .apk (can be run at the same time as original SC without affecting it) published in this issue:

If it works ok in MapLibre part of the screen, than those display issues may be an additional argument for making the move from Tangrem-ES to Maplibre (especially as more and more devices are going to be Android 12+, and many languages contain non-ASCII names)

@CTJoriginal
Copy link
Contributor Author

CTJoriginal commented May 9, 2023

MapLibre version seems to work perfectly!

SmartSelect_20230509_172211_ML StreetComplete.jpg

I also tried with greek letters "Σπιτική" from another issue

@soshial
Copy link

soshial commented Sep 6, 2023

We also got this problem in Latvia :(
With street names and neighbourhoods.

@mnalis
Copy link
Member

mnalis commented Sep 6, 2023

@soshial and what Android version is that (and what SC version)?

For me (SC 53.3 on Android 10/EMUI 12) the same region displays fine:

small_Screenshot_20230906_215309_de westnordost streetcomplete

So far, it seem to be happening only on newer android versions. Unfortunately, as stated above, this is bug in Tangrem-es library, which seems to be abandoned, so it is very unlikely to be fixed. Possible solution is porting StreetComplete to use Maplibre instead of Tangrem-es, but that is no small job.

@soshial
Copy link

soshial commented Sep 14, 2023

@mnalis

@soshial and what Android version is that (and what SC version)?

Street Complete v54.0
Samsung Galaxy S22 with Android 13

@RubenKelevra
Copy link
Contributor

@soshial can you confirm that it's fixed in version 59.0 Alpha 1?

Here under Android 12 it looks fine now:

Screenshot_2024-08-23-14-27-01-269-edit_de westnordost streetcomplete

@mnalis
Copy link
Member

mnalis commented Aug 23, 2024

For me (SC 53.3 on Android 10/EMUI 12) the same region displays fine:

And (again for me) on Android 14 it is broken (in all Tangram-ES versions, i.e. anything below v59.0-alpha1).

So it seems it broke with Android 13, and also it will be fixed with StreetComplete v59.0 release.

As e.g. shown here in that old testing version which displayed both Tangram-ES and MapLibre at the same time (this screenshot taken on Android 14):
small_Screenshot_20240823_143514_ML StreetComplete

one can clearly see Tangram-ES (left) side is broken, while MapLibre (right) side is fine.
If using Android 12 and below, both would be looking fine.

@soshial
Copy link

soshial commented Aug 23, 2024

It looks like 59.0-alpha1 fixed it for my Samsuns S22 (Android 14).
Although, I haven't tested it with letters that have double diacritics (e.g. in Svan language or Livonian language). Have you tried it? Can't find such examples on a map.
Also, I couldn't find native titles on a map at all 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

7 participants