suite: missing signature check before calling Test* method

[wvell]

If a test method on a suite has a parameter there is a panic:

func (suite *SomeTestSuite) TestUpdateSomething(somearg string) {
......
}

When running this you get the following panic:

suite.go:87: test panicked: reflect: Call with too few input arguments
....

I think the error handling could be more clear here. Something like "method TestUpdateSomething on SomeTestSuite contains arguments"

Here is the go.dev link: https://go.dev/play/p/cNNfqH5QpeQ

I can create a pull request if this change is wanted?

Edit: Some more context. I run into this problem when I am porting old test methods to a suite.

[dolmen]

Please provide an example running on go.dev/play.

[wvell]

I've added a go.dev example.

[dolmen]

This is definitely a dirty bug: Suite should check the method signature and report a test failure if the type doesn't match.

A PR would be welcome.

[vyas-git]

Hi, I would like to take this up, so please assign me to the issue.

I’ve noticed the PR linked to this issue, but I’m not sure if it’s still active. I have raised a new PR with the required improvements. I agree with @dolmen's point that we should check for invalid method signatures earlier in the flow, after the methodFilter.

Additionally, I used t.Errorf instead of t.Fatalf to report invalid method signatures while continuing the execution of valid methods. The PR also includes additional test scenarios covering both valid and invalid method signatures.

You can find the new PR here.

@brackendawson @dolmen @arjunmahishi Let me know your thoughts or if any further changes are needed!