mock: clear call from NotBefore expectations on Unset() #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3penta
force-pushed
the
fix-unset-notbefore
branch
from
f6aceb7
to
dfed0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
Call.Unsetmethod was not properly clearing the dependency established by theCallB.NotBefore(CallA)method, which stipulates that CallA should precede CallB. Consequently, the expectations for CallB were failing because it was still anticipating CallA.Changes
This PR adds the field
requiredByto theCallobject, that tracks the dependentCallinstances (e.g: CallB, in the above example).This field is used in the
Unsetmethod to clear theNotBeforeexpectations from the dependent calls.Related issues
Closes #1542