Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Full screen is not working on the reader #355

Open
jayjoshi64 opened this issue Jun 26, 2024 · 4 comments
Open

[BUG] Full screen is not working on the reader #355

jayjoshi64 opened this issue Jun 26, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@jayjoshi64
Copy link

Describe the bug
Clicking on full screen icon does nothing.

To Reproduce

  1. Open any ebooks (I am using .epub book)
  2. Click on the full screen.
  3. ...Nothing happens

Expected behavior
The reader view should be full screened

Screenshots
Jun-26-2024 12-54-03

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Edge & Chrome
@jayjoshi64 jayjoshi64 added the bug Something isn't working label Jun 26, 2024
@aaronleopold
Copy link
Collaborator

aaronleopold commented Jun 26, 2024

This isn't actually a bug, just perhaps misleading and/or bad UX.

The header and footer UI components are fixed and constantly visible. When you enter "full screen" mode they instead hide after a second or two of losing focus / mouse exit.

It does not control your browser's full screen functionality.

@jayjoshi64
Copy link
Author

I see. Let's make it a little obvious if possible.

  • tbh, the header is so small, I don't think this makes that much sense in desktop version. But for phone, it might be good to have.
  • adding some reaction would be helpful. For example, instead of waiting for the mouse to exit the component, we can immediately hide the menu. And instead, we can add a small down arrow which use can click to unhide it. Many web apps use such feature.
  • also, the button is unresponsive. Changing the icon a little bit can also help. But this would be secondary.

@jayjoshi64
Copy link
Author

jayjoshi64 commented Jun 26, 2024

Although, it's not the most important thing probably. I'll see if I can raise a PR in few weeks. I'll also check if I can directly add the functionality to support browser full screen.

@aaronleopold
Copy link
Collaborator

Yeah for sure, I'm down to play with the UI to improve the overall experience. I won't have time in the immediate few weeks, as I am focusing on a few other features already, but can make some time afterwards.

I'll see if I can raise a PR in few weeks.

If you need anything please reach out! There is a dedicated dev channel on the Discord, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants