Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - ADD RENOVATEBOT FOR GOLANG DEPENDECIES #47

Closed
2 tasks done
patrick-hermann-sva opened this issue May 16, 2024 · 3 comments · Fixed by #57
Closed
2 tasks done

[FEATURE] - ADD RENOVATEBOT FOR GOLANG DEPENDECIES #47

patrick-hermann-sva opened this issue May 16, 2024 · 3 comments · Fixed by #57
Assignees

Comments

@patrick-hermann-sva
Copy link
Contributor

patrick-hermann-sva commented May 16, 2024

  • add bot
  • test
@xlai89
Copy link
Contributor

xlai89 commented May 16, 2024

initialized renovate.
next step: enable automerge

  • status check required
  • strategy: ff & rebase

@xlai89
Copy link
Contributor

xlai89 commented May 16, 2024

Automerge and a schedule were enabled according to this best practice in PR #57 and #58.

A setting modification for main branch was necessary to set successful pipelines in the env "k8s" as required before merging PR, otherwise PR got automerged before finishing pipelines, like #59.

@xlai89
Copy link
Contributor

xlai89 commented May 18, 2024

Automerge works generally well. There is one issue though:

Successful checks (github action pipelines) are prerequisites for an automerge. If the main branch got new commits during the time when a renovate PR is open, rebase will take place after checks. But rebasing does not trigger new checks, causing 0 checks in the renovate PR, preventing automerge.

Workaround: close the PR and reopen it. If the checks succeed, automerge will take place and dependencies get updated.

Currently prHourlyLimit is set to 1, avoiding concurrent renovate PRs during the renovate schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants