Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Emit diagnostics for ranges instead of single positions #336

Open
1 task done
adalinesimonian opened this issue Nov 18, 2021 · 4 comments · Fixed by #358
Open
1 task done

[Feature]: Emit diagnostics for ranges instead of single positions #336

adalinesimonian opened this issue Nov 18, 2021 · 4 comments · Fixed by #358
Labels
status: blocked is blocked by another issue or pr type: enhancement a new feature that isn't related to rules upstream relates to an upstream package
Milestone

Comments

@adalinesimonian
Copy link
Member

What problem does this feature solve?

Unlike other linter integrations, we only display diagnostics for a single position. This makes for a confusing and less useful experience for users.

How does this feature solve the problem?

We should emit diagnostics for ranges that better describe the location of problems.

What are some alternatives to this feature?

No response

Code of Conduct

  • I agree to follow vscode-stylelint's Code of Conduct
@adalinesimonian adalinesimonian added type: enhancement a new feature that isn't related to rules status: blocked is blocked by another issue or pr upstream relates to an upstream package labels Nov 18, 2021
@adalinesimonian adalinesimonian added this to the On Deck milestone Nov 18, 2021
@adalinesimonian
Copy link
Member Author

Blocked by stylelint/stylelint#5694

@kizu
Copy link
Member

kizu commented Feb 21, 2023

Just want to mention that the issue that was blocking this was fixed — now stylelint provides optional endLine and endColumn, which, when present, could be used to define a range to report.

I'm not familiar with where to look in the plugin to implement this, so maybe someone more knowledgable about the plugin's codebase could look into it, or maybe point me toward where to look at — then if I would find time, I could introduce this change.

@jeddy3
Copy link
Member

jeddy3 commented Feb 21, 2023

@kizu I believe the bulk of the work was done in #358. There hasn't been the time to get it over the finish line, though. I think there are a few dependent PRs and issues to wrangle (#426 and so on).

If you do find time, then taking a look would be fantastic! I've added you as a member to the Stylelint org (it should have happened automatically after your pull request in the stylelint/stylelint repo was merge, but the bot is playing up), so that you can push directly to the WIP branches if you want.

@adalinesimonian
Copy link
Member Author

I appreciate the help! #426, if I remember correctly, should be a good base to improve and add this support from. I've sadly not had the time, as just as I was supposed to free up last year, my company's engineering department went through a re-organization, and after the new year came around, my father ended up falling seriously ill. C'est la vie.

#426 should also introduce upstream changes from adalinesimonian/jest-runner-vscode to get e2e tests passing. I'm happy to provide answers and assist if anything comes up, but for the time being, I don't have the bandwidth to implement these changes myself. Thanks for your interest in the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked is blocked by another issue or pr type: enhancement a new feature that isn't related to rules upstream relates to an upstream package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants