Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimum build target to 10.14 #197

Open
jncn opened this issue Dec 15, 2020 · 2 comments · May be fixed by #198
Open

Set minimum build target to 10.14 #197

jncn opened this issue Dec 15, 2020 · 2 comments · May be fixed by #198
Assignees
@jncn
Labels
enhancement New feature or request help wanted Contributions extra welcome, as core maintainers probably won't get to it soon. maintenance Maintenance tasks like modernisation, fix of warnings and deprecations
Milestone
v5.3

Comments

@jncn
Copy link
Collaborator

jncn commented Dec 15, 2020 •
edited
Loading

This allows for less version checks and further modernisation of the app.

Questions:

  • Xcode recommends to enable some warnings. Given the age of the code base, I suspect it'll require quite some work to satisfy the compiler. Even though this will make the code base much stricter, I'd actually do this to prevent running in to trouble later.

Screenshot 2020-12-15 at 18 07 48

Related issues:
@jncn jncn self-assigned this Dec 15, 2020
@jncn jncn added enhancement New feature or request help wanted Contributions extra welcome, as core maintainers probably won't get to it soon. maintenance Maintenance tasks like modernisation, fix of warnings and deprecations labels Dec 15, 2020
@jncn jncn linked a pull request Dec 15, 2020 that will close this issue
Draft
@monkeydom
Copy link
Contributor

I'm torn with the recommended warnings. I'm quite against nullability e.g. and also implicit conversion 32/64 and signed/unsigned usually just increases friction a lot and sometimes also adds bugs in the adoption as it needs to be carefully.

Overall: warnings need to be kept to 0 at all times, and the #37 already prevents this as of now. So it is not acceptable to enable warnings and not fix them at the same time to me, generally speaking.

@monkeydom monkeydom linked a pull request Dec 16, 2020 that will close this issue
10.14 Build Target #198
Draft
@jncn jncn added this to the v5.2 milestone Dec 16, 2020
@monkeydom monkeydom modified the milestones: v5.2, v5.3 Mar 2, 2021
@rtharston
Copy link

Xcode 14 added RECOMMENDED_MACOSX_DEPLOYMENT_TARGET environment variable and suggests using it in the build settings update prompt.

RECOMMENDED_MACOSX_DEPLOYMENT_TARGET is currently set to 10.14.6. Instead of updating to 10.14 how about using the new recommended target value of 10.14.6?

I'd understand if @monkeydom doesn't want to use RECOMMENDED_MACOSX_DEPLOYMENT_TARGET directly to avoid issues with it changing unexpectedly, but I think that if Apple has a reason to recommend 10.14.6 instead of 10.14 then there might be good reason for SubEthaEdit to jump to that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jncn jncn

Labels
enhancement New feature or request help wanted Contributions extra welcome, as core maintainers probably won't get to it soon. maintenance Maintenance tasks like modernisation, fix of warnings and deprecations
Projects
None yet
Milestone
v5.3
Development

Successfully merging a pull request may close this issue.

10.14 Build Target jncn/SubEthaEdit
3 participants
@monkeydom @jncn @rtharston