Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize loop in range client program #73

Closed
zobront opened this issue Aug 27, 2024 · 1 comment
Closed

Optimize loop in range client program #73

zobront opened this issue Aug 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@zobront
Copy link
Collaborator

zobront commented Aug 27, 2024

Currently, the main loop of the range client program calls driver.produce_payloads(), which calls step() on the pipeline, and then loops over all available attrs in the pipeline and returns a vector of all of them.

However, after calling step() once only one attr at a time is made accessible. So the vector will have a length of at most one.

This allows us to slightly simplify the logic, by just returning an Option for a single payload attribute, and then executing that in the main loop without having to iterate over the vector.

@zobront zobront added the enhancement New feature or request label Aug 27, 2024
@ratankaliani
Copy link
Member

Added in #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants