From 64faf8b2de5edd69e60d14711f9b32f8af667396 Mon Sep 17 00:00:00 2001
From: nhtyy <n@push0.dev>
Date: Mon, 25 Nov 2024 10:01:18 -0800
Subject: [PATCH] chore: all feats, no feats, default feats top level workspace
 checks

---
 .github/workflows/pr.yml        | 20 ++++++++++++++++++++
 crates/core/executor/Cargo.toml |  2 +-
 crates/verifier/src/tests.rs    |  4 ++++
 3 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
index 391d00322c..082b3bc16b 100644
--- a/.github/workflows/pr.yml
+++ b/.github/workflows/pr.yml
@@ -146,6 +146,26 @@ jobs:
         env:
           CARGO_INCREMENTAL: 1
 
+      - name: Check workspace no features
+        uses: actions-rs/cargo@v1
+        with:
+          command: check
+          args: --workspace --all-targets --no-default-features
+
+      - name: Check workspace with default features
+        uses: actions-rs/cargo@v1
+        with:
+          command: check
+          args: --workspace --all-targets
+
+      - name: Check workspace with all features
+        uses: actions-rs/cargo@v1
+        with:
+          command: check
+          args: --workspace --all-targets --all-features
+
+
+
   examples:
     name: Examples
     runs-on:
diff --git a/crates/core/executor/Cargo.toml b/crates/core/executor/Cargo.toml
index 3c09170d6f..2cbf03a117 100644
--- a/crates/core/executor/Cargo.toml
+++ b/crates/core/executor/Cargo.toml
@@ -44,7 +44,7 @@ enum-map = { version = "2.7.3", features = ["serde"] }
 test-artifacts = { workspace = true, optional = true }
 
 [dev-dependencies]
-sp1-zkvm = { workspace = true }
+sp1-zkvm = { workspace = true, features = ["lib"] }
 
 [features]
 programs = ["dep:test-artifacts"]
diff --git a/crates/verifier/src/tests.rs b/crates/verifier/src/tests.rs
index c6d9a853c6..f33500875d 100644
--- a/crates/verifier/src/tests.rs
+++ b/crates/verifier/src/tests.rs
@@ -1,6 +1,8 @@
+#[cfg(feature = "std")]
 use sp1_sdk::{install::try_install_circuit_artifacts, SP1ProofWithPublicValues};
 
 #[test]
+#[cfg(feature = "std")]
 fn test_verify_groth16() {
     // Location of the serialized SP1ProofWithPublicValues. See README.md for more information.
     let proof_file = "test_binaries/fibonacci-groth16.bin";
@@ -19,6 +21,7 @@ fn test_verify_groth16() {
 }
 
 #[test]
+#[cfg(feature = "std")]
 fn test_verify_plonk() {
     // Location of the serialized SP1ProofWithPublicValues. See README.md for more information.
     let proof_file = "test_binaries/fibonacci-plonk.bin";
@@ -37,6 +40,7 @@ fn test_verify_plonk() {
 }
 
 #[test]
+#[cfg(feature = "std")]
 fn test_vkeys() {
     let groth16_path = try_install_circuit_artifacts("groth16");
     let s3_vkey_path = groth16_path.join("groth16_vk.bin");