feat(verifier): verify_bytes api GRO-304 #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: yuwen/verifier-bytes-api
|
yuwen01
changed the title
| ### Advanced: `verify_bytes` | ||
|
|
||
| `sp1-verifier` also exposes [`Groth16Verifier::verify_bytes`](https://docs.rs/sp1-verifier/latest/sp1_verifier/struct.Groth16Verifier.html#method.verify_bytes) and [`PlonkVerifier::verify_bytes`](https://docs.rs/sp1-verifier/latest/sp1_verifier/struct.PlonkVerifier.html#method.verify_bytes), | ||
| which verifies any Groth16 or Plonk proof from gnark. This is especially useful for verifying custom Groth16 and Plonk proofs |
There was a problem hiding this comment.
Fix: Capitalize Gnark, and add a link to https://docs.gnark.consensys.io/, or the repo.
zkVM, instead of ZKVM.
| } | ||
| ``` | ||
|
|
||
| Public values are serialized as big-endian `Fr` values. The default gnark serialization will work |
crates/verifier/src/groth16/mod.rs
Outdated
| /// | ||
| /// This method expects the raw proof bytes without the 4-byte vkey hash prefix that | ||
| /// [`verify`] checks. If you have a complete proof with the prefix, use [`verify`] instead. | ||
| pub fn verify_bytes( |
There was a problem hiding this comment.
Better name is verify_gnark_proof. verify_bytes isn't that specific. We should also add documentation to the function above to say that it's for SP1 proofs.
jtguibas
reviewed
Nov 12, 2024
| /// | ||
| /// This method expects the raw proof bytes without the 4-byte vkey hash prefix that | ||
| /// [`verify`] checks. If you have a complete proof with the prefix, use [`verify`] instead. | ||
| pub fn verify_gnark_proof( |
jtguibas
reviewed
Nov 12, 2024
| /// | ||
| /// A [`Result`] containing unit `()` if the proof is valid, | ||
| /// or a [`PlonkError`] if verification fails. | ||
| pub fn verify_gnark_proof( |
jtguibas
reviewed
Nov 12, 2024
| @@ -44,7 +44,7 @@ pub(crate) struct PlonkVerifyingKey { | |||
| /// # Returns | |||
| /// | |||
| /// * `Result<bool, PlonkError>` - Returns true if the proof is valid, or an error if verification fails | |||
| pub(crate) fn verify_plonk_raw( | |||
| pub(crate) fn verify_plonk_algebraic( | |||
There was a problem hiding this comment.
add #[must_use] so people don't forget to unwrap
There was a problem hiding this comment.
must_use is already on by default for Result. doing something like this gives me a warning
crate::PlonkVerifier::verify(...);
jtguibas
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://succinctlabs.slack.com/archives/C04Q4J7KUBE/p1731323036949519