Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem when removing a FileReference #3

Open
devmes opened this issue Sep 18, 2023 · 1 comment
Open

Problem when removing a FileReference #3

devmes opened this issue Sep 18, 2023 · 1 comment

Comments

@devmes
Copy link

devmes commented Sep 18, 2023

When a property of type Filereference is deleted or set to empty, the backend module crashes with an error.

The reason for this is that in the class SUDHAUS7\FeDataHistory\Traits\HistoryRecord in the function writeModified in the last Else conditions at $oldRecord is not considered whether it is an object. If it is an object, only the UID may be used.
image
foppelfb added a commit that referenced this issue Sep 18, 2023
@foppelfb
[FEATURE] fe-data-history-3 Problem when removing a FileReference
bbf4dd0 
Tasks:
* add check if oldValue is in fact a reference

Resolves: #3
@foppelfb
Copy link
Member

Can you please check the branch issue-3 if that works for your case?

Another question: why do you send a screen-shot with updated code instead of a patch, or - even better - a merge-request? Seems to be excessive effort to display a point ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foppelfb @devmes