Feedback form reCAPTCHA fails intermittently

[taylor-steve]

Sometimes, for unauthenticated users, the Feedback form Captcha will show the green success checkmark but the form will fail to submit with the error "You must pass the reCAPTCHA challenge".

At first glance this seems similar to #3808 in the sense that sometimes the noscript tags are processed by the browser and sometimes they are not, causing the 'g-recaptcha-response' to be empty for the form. The reason for this was clear in #3808, less so here as it is very intermittent and can vary from reload to reload on the same page.

I can recreate fairly reliably by:

• Viewing, not submitting, the feedback form at the SearchWorks homepage
• Selecting the "Online" Access facet and viewing the feedback form on that page. This will tend not to work.

Inspecting the recaptcha source, when you see this, the form will work:

When seeing this, the form will fail:

Turning off noscript like in #3808 appears to work, but I'm less clear on why we would need to do this here.

[taylor-steve]

Seems to have started with v3.21.14.

Maybe the switch to turbo?
ambethia/recaptcha#407

[taylor-steve]

Noting that this behavior occurs with any noscript tags in that form. It does not seem to be specific to reCAPTCHA or the recaptcha gem.

[taylor-steve]

For reference, this noscript behavior happens anywhere in SeachWorks, but does not seem to impact behavior except in cases like reCAPTCHA where it is storing an empty g-recaptcha-response in the noscript elements.

Niqui found a link that seems to suggest it might be turbo related:

https://discuss.hotwired.dev/t/turbo-processes-noscript-children-when-merging-head/2552

It appears this wouldn't be an issue if we wanted to add our own noscript elements to those forms in the future.