Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #252 - Build command fails when using Postgres #253

Open
wants to merge 2 commits into
base: 0.8
Choose a base branch
from

Conversation

ajdinmore
Copy link
Contributor

Just a quick fix, hope you're okay with what I've done for the index name generation.

Pull should be good for both 0.6 and 0.7 branches.

Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the merge request please create a entry for UPGRADE to move existing indexes from idx_<column> to idx_<your_entity>_<column>

Comment on lines +120 to +125
CREATE INDEX idx_<your_entity>_dimension ON <your_entity>_content (stage, locale);
CREATE INDEX idx_<your_entity>_locale ON <your_entity>_content (locale);
CREATE INDEX idx_<your_entity>_stage ON <your_entity>_content (stage);
CREATE INDEX idx_<your_entity>_template_key ON <your_entity>_content (templateKey);
CREATE INDEX idx_<your_entity>_workflow_place ON <your_entity>_content (workflowPlace);
CREATE INDEX idx_<your_entity>_workflow_published ON <your_entity>_content (workflowPublished);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not edit the old UPGRADE this need be part of a new upgrade migrating existing idx_dimension to idx_your_entity>_...

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label Jul 3, 2024
@alexander-schranz alexander-schranz changed the base branch from 0.9 to 0.8 November 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants