Fix sign out of oauth provider #111
Conversation
There was a problem hiding this comment.
Actually, now that I think about it after seeing this PR, it might be better to leave it up to the developer to sign out from Google accounts. I personally don't think introducing a new sign-out method is a good developer experience upgrade.
Maybe we can just add comments on the third-party sign-in methods that singing out from the third party auth provider should be handled by the developer and call it a day?
|
We can do that too. |
|
I'm just not a fan of having two separate sign out methods. It's very counter intuitive, and feel like would cause confusion. There is also the issue of discoverability. I think the way to solve this issue is with good documentation. |
|
Agreed |
What kind of change does this PR introduce?
Logs out the google provider
What is the current behavior?
Closes #78
What is the new behavior?
Logs out of the google provider and the supabase session, making the chooser appear whenever the user tries to log back in.