Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Confirmation on User's Demand, currently relies on SDK request #2981

Open
smaroudasunicorn opened this issue Apr 18, 2024 · 6 comments · May be fixed by #3290
Open

Investigate Confirmation on User's Demand, currently relies on SDK request #2981

smaroudasunicorn opened this issue Apr 18, 2024 · 6 comments · May be fixed by #3290
Assignees

Comments

@smaroudasunicorn
Copy link
Collaborator

No description provided.

@onvisions
Copy link
Collaborator

As requested by @CedrikNikita I'm providing a template for Unknown URL case of a third party dapp that might be malicious with high probability.

DESIGN:
Tx Access, Sign, Raw tx-1
Tx Access, Sign, Raw tx-2

FIGMA REFERENCE:
https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=34379-240771&node-type=instance&t=9seIxZoOgv2mi7mz-0

Other than that I think it's high time to implement the updated version of all these templates for signing messages, allowing access, RAW transactions, with errors and warnings, etc. I have designed (and synced with Nikita) pretty neat templates which require only minor modifications of our existing template but will bring more consistency and professional look and feel of the UI as currently it's a bit messed up. Also it creates confusion for QA team while testing as the Figma reference is different from implementation.
@smaroudasunicorn may be we can include it as task in the next sprint. I don't see huge amount of work needed but rather more attention to details such as colors, opacity, labels, wording, external linking with proper icons, updated button labels etc.

@smaroudasunicorn smaroudasunicorn self-assigned this Sep 18, 2024
@smaroudasunicorn
Copy link
Collaborator Author

smaroudasunicorn commented Sep 18, 2024

An external source is requesting to connect with our wallet, sign a transaction/message. We should always display the modal and the origin of the request or that the origin URL is unknown.

Tick box is not need a simple information is enough. Also instead of unknown dapp I would put Unknown Source.

@onvisions
Copy link
Collaborator

onvisions commented Sep 19, 2024

@smaroudasunicorn

  1. We always display the confirmation modal, there is no question about it.

If you think the checkbox is overkill it is easy to be removed. However...

  1. In the case of Unknown URL an unknown source is asking for access and most probably this means that the user is being scammed or there is high probability of loss of funds and other undesired consequences. Only in this case we should display the checkbox to make sure user is aware of the risks and not proceeding without reading the warning (all the other templates that can be seen in Figma do not have a checkbox). So my suggestion is to keep the checkbox for this case that will be rarely experienced.

@onvisions
Copy link
Collaborator

onvisions commented Sep 19, 2024

@smaroudasunicorn Updated design and wording:

Tx Access, Sign, Raw tx

What do you think about that (from my previous comment):

It's high time to implement the updated version of all these templates for signing messages, allowing access, RAW transactions, with errors and warnings, etc. I have designed (and synced with Nikita) pretty neat templates which require only minor modifications of our existing template but will bring more consistency and professional look and feel of the UI as currently it's a bit messed up. Also it creates confusion for QA team while testing as the Figma reference is different from implementation.
May be we can include it as task in the next sprint. I don't see huge amount of work needed but rather more attention to details such as colors, opacity, labels, wording, external linking with proper icons, updated button labels etc.

Figma reference for confirmation templates:
https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=31920-206747&node-type=frame&t=AoAt0agBepVfhnXP-0

@smaroudasunicorn
Copy link
Collaborator Author

Kindly ensure that you are aware of the request origin. Allowing access might cause undesired results, including loss of your funds.

@onvisions
Copy link
Collaborator

Tx Access, Sign, Raw tx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants