-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Confirmation on User's Demand, currently relies on SDK request #2981
Comments
As requested by @CedrikNikita I'm providing a template for Unknown URL case of a third party dapp that might be malicious with high probability. Other than that I think it's high time to implement the updated version of all these templates for signing messages, allowing access, RAW transactions, with errors and warnings, etc. I have designed (and synced with Nikita) pretty neat templates which require only minor modifications of our existing template but will bring more consistency and professional look and feel of the UI as currently it's a bit messed up. Also it creates confusion for QA team while testing as the Figma reference is different from implementation. |
An external source is requesting to connect with our wallet, sign a transaction/message. We should always display the modal and the origin of the request or that the origin URL is unknown. Tick box is not need a simple information is enough. Also instead of unknown dapp I would put Unknown Source. |
If you think the checkbox is overkill it is easy to be removed. However...
|
@smaroudasunicorn Updated design and wording: What do you think about that (from my previous comment):
Figma reference for confirmation templates: |
Kindly ensure that you are aware of the request origin. Allowing access might cause undesired results, including loss of your funds. |
No description provided.
The text was updated successfully, but these errors were encountered: