Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't refresh page after resetting the wallet #3307

Open
peronczyk opened this issue Oct 11, 2024 · 5 comments · May be fixed by #3306
Open

Don't refresh page after resetting the wallet #3307

peronczyk opened this issue Oct 11, 2024 · 5 comments · May be fixed by #3306
Assignees

Comments

@peronczyk
Copy link
Collaborator

peronczyk commented Oct 11, 2024

If user resets the wallet the page should not be refreshed.

Initially refreshing the page was solving this issue found on mobile: #650 (comment)

This PR requires testing resetting the wallet only on web.

@peronczyk peronczyk self-assigned this Oct 11, 2024
@peronczyk peronczyk linked a pull request Oct 11, 2024 that will close this issue
@Liubov-crypto
Copy link
Collaborator

LGTM

@peronczyk
Copy link
Collaborator Author

peronczyk commented Oct 14, 2024

After talking with @CedrikNikita I decided to totally remove the action that refreshes the page for every environment (web/popup/mobile). Can you please retest this @Liubov-crypto but this time for every env? Nikita has concerns that without refreshing the page user could see some data from the previous accounts in his wallet when using new mnemonic. Can you please focus also on this?

@Liubov-crypto
Copy link
Collaborator

Liubov-crypto commented Oct 14, 2024

@peronczyk , @CedrikNikita is correct, I can see latest Tx from the previous account when I reset prev wallet and login with new account:

2024-10-14.4.19.55.mov

checked on web/ext/android app

@peronczyk
Copy link
Collaborator Author

Thanks @Liubov-crypto . I added a fix for this issue. Now resetting the wallet also wipes the transactions:
Image

Can you retest please?

@Liubov-crypto
Copy link
Collaborator

Still reproducible for me:

2024-10-21.1.57.23.mov

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants