-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't refresh page after resetting the wallet #3307
Comments
LGTM |
After talking with @CedrikNikita I decided to totally remove the action that refreshes the page for every environment (web/popup/mobile). Can you please retest this @Liubov-crypto but this time for every env? Nikita has concerns that without refreshing the page user could see some data from the previous accounts in his wallet when using new mnemonic. Can you please focus also on this? |
@peronczyk , @CedrikNikita is correct, I can see latest Tx from the previous account when I reset prev wallet and login with new account: 2024-10-14.4.19.55.movchecked on web/ext/android app |
Thanks @Liubov-crypto . I added a fix for this issue. Now resetting the wallet also wipes the transactions: Can you retest please? |
If user resets the wallet the page should not be refreshed.
Initially refreshing the page was solving this issue found on mobile: #650 (comment)
This PR requires testing resetting the wallet only on web.
The text was updated successfully, but these errors were encountered: