Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation modal: dApp requesting permission to switch network #3429

Open
onvisions opened this issue Nov 29, 2024 · 5 comments · May be fixed by #3431
Open

Confirmation modal: dApp requesting permission to switch network #3429

onvisions opened this issue Nov 29, 2024 · 5 comments · May be fixed by #3431
Assignees

Comments

@onvisions
Copy link
Collaborator

onvisions commented Nov 29, 2024

Story: design is needed for a confirmation modal in case dApp is requesting permission to switch the active network. Requested by @CedrikNikita

UX Suggestion: @smaroudasunicorn @CedrikNikita based on some research how other wallets are dealing with same scenario I am suggesting to grant the dApp permission to switch the network just once within the initial Connect to dApp modal instead of asking the user each time.

Design:

Image

Figma reference: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=38011-279097&node-type=instance&t=H26uNHOEsBqsmksW-0

@CedrikNikita
Copy link
Collaborator

I think from now on we should show the network in the transaction confirmation screen. Because after this changes the app would be able to change the network silently.

@onvisions
Copy link
Collaborator Author

onvisions commented Dec 3, 2024

@smaroudasunicorn , @CedrikNikita: the connected network status display is incorporated in this design suggestion. It is not interactive, just display.

Story: the user has no account created on the blockchain the dApp is operating on. They need to see a message warning them they cannot use the dApp without such an account. The message is similar to what we show on the Wallet Connect modal when user has no Ethereum account.

Design:
Image
Image

Figma reference: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=38051-290048&node-type=frame&t=EhlxZVKaSHRf2pmR-0

@CedrikNikita CedrikNikita linked a pull request Dec 6, 2024 that will close this issue
@Liubov-crypto
Copy link
Collaborator

A little bit different design compared to Figma, it doesn't show a current account:

dap

aa

@onvisions
Copy link
Collaborator Author

onvisions commented Dec 11, 2024

@Liubov-crypto @CedrikNikita @smaroudasunicorn
Well, although my design suggestion was to show the current active account, I like this one too. 2 things to improve just visually:

  • make the size of both greyed sections equal (dApp and Wallet with the loading animation);
  • increase margin on top of the error message (like in design);
  • may be instead of the diamond we can also show the default UI skeleton animation already implemented by Alexandros?

! Another issue with this design might be that user may think we are waiting for something to load which is not the case.

@Liubov-crypto
Copy link
Collaborator

Liubov-crypto commented Dec 12, 2024

@onvisions Currently we are having thess ones:

Image
Image

Probably design changes will be implemented later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants