Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If user set daily spending limit without asking wallet will sign in Tx but will not redirect to the app #3430

Open
Liubov-crypto opened this issue Dec 3, 2024 · 2 comments · May be fixed by #3434
Assignees

Comments

@Liubov-crypto
Copy link
Collaborator

Describe the bug
I found that sometimes when I buy token or sell token on token org, confirmation popup (allow token) can be signed by wallet himself without my interaction

To Reproduce
Steps to reproduce the behavior:

  1. Go to token org
  2. Try to buy or sell token
  3. Check Txs in wallet

Expected behavior
User have to approve all Tx in wallet by himself

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: iPhone
  • ios
  • chrome, FF, safari

Additional context
Reproducible with current release branch app and token org.

@Liubov-crypto
Copy link
Collaborator Author

Liubov-crypto commented Dec 5, 2024

Retested with android app and chrome mob browser and it works as expected.

Retested with iOS app and Safari browser.
I set in permission settings daily limit without asking 1 ae, then I tried to sell 10 tokens that I bought before . First Tx (allow use of token ) was signed by wallet automatically. I was redirected to token.org. But I haven't received the second Tx in the wallet to sign it, to sell token actually.
token org is stuck, I was not redirected to the wallet and no sell Txs in the wallet list on the final step.

@Liubov-crypto Liubov-crypto changed the title Confirmation popup can be signed by wallet himself without my interaction If user set daily spending limit without asking wallet will sign in Tx but will not redirect to the app Dec 5, 2024
@alex-k8 alex-k8 linked a pull request Dec 9, 2024 that will close this issue
@Liubov-crypto
Copy link
Collaborator Author

Fixed, tested with Chrome extension.

I have a question: it seems that incoming Txs are not displaying in our wallet Tx list and in this case Permission settings---> daily spending without limit will not calculate properly.
For example I set 1 ae as spending limit without asking, then I sold a couple of tokens, but these Txs were not calculated in my total spending limit. Only buy Tx were calculated. Also I can't see the "proper income" Tx in my list that I have sold tokens, only approve allowance use of token.

account: ak_cEjh5on5RvoBw8zqCGS4VWeY2bmNYNPjn3SCZutYyVLWKf7X1
Txs: https://testnet.aescan.io/transactions/th_BPnmsExHU4VwTSEXwBujUKGXxAuwy2ADn4iWtcPtvSzECLzRz
https://testnet.aescan.io/transactions/th_uXedCh13kXqqxDReWW14G7wzkTnAFPSFWSx1V4dynguVdneN8
https://testnet.aescan.io/transactions/th_2QQFgyzNNRE3DtMW4WQa5bEpRxbqfzaXeXHLLUzXGCVrPobiaC
https://testnet.aescan.io/transactions/th_mkCW37wfFsEXWDYNr2pe6KoAGwKZDQ6TPpzG3NwMgfzQSgBQV

and one more question:

I sold 10 tokens but see them as 90 in the wallet Tx. Why is there such big difference?

10
https://testnet.aescan.io/transactions/th_mkCW37wfFsEXWDYNr2pe6KoAGwKZDQ6TPpzG3NwMgfzQSgBQV

Should I create bug tickets for these cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants