Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SuperEditor][SuperReader] - Migrate iOS overlays to OverlayPortal #1526

Closed
matthew-carroll opened this issue Oct 16, 2023 · 0 comments · Fixed by #1661
Closed

[SuperEditor][SuperReader] - Migrate iOS overlays to OverlayPortal #1526

matthew-carroll opened this issue Oct 16, 2023 · 0 comments · Fixed by #1661
Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time:2

Comments

@matthew-carroll
Copy link
Contributor

We migrated SuperEditor and SuperReader to use OverlayPortal along with overlay display priorities in #1524

But we only made those changes for Android, because there's a huge PR for other iOS behavior that I didn't want to conflict with: #1470

After the big iOS PR is merged, migrate the iOS controls to user OverlayPortal too.
@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time:2 area_super_reader Related to SuperReader labels Oct 16, 2023
matthew-carroll added a commit that referenced this issue Dec 10, 2023
@matthew-carroll
Migrated SuperEditor and SuperReader iOS overlays to OverlayPortal - …
1cd69d7 
…all overlays in this package should now use OverlayPortal (Resolves #1526)
@matthew-carroll matthew-carroll mentioned this issue Dec 10, 2023
Merged
matthew-carroll added a commit that referenced this issue Dec 11, 2023
@matthew-carroll
Migrated SuperEditor and SuperReader iOS overlays to OverlayPortal - …
797bd47 
…all overlays in this package should now use OverlayPortal (Resolves #1526) (#1661)
github-actions bot pushed a commit that referenced this issue Dec 11, 2023
@matthew-carroll @web-flow
Migrated SuperEditor and SuperReader iOS overlays to OverlayPortal - …
cadeee6 
…all overlays in this package should now use OverlayPortal (Resolves #1526) (#1661)
matthew-carroll added a commit that referenced this issue Dec 11, 2023
@matthew-carroll
Migrated SuperEditor and SuperReader iOS overlays to OverlayPortal - …
788d881 
…all overlays in this package should now use OverlayPortal (Resolves #1526) (#1661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time:2
Projects
None yet
Milestone
No milestone
1 participant
@matthew-carroll