Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store tokens in frontend cookies by default in header based auth #223

Open
rishabhpoddar opened this issue Jun 7, 2023 · 0 comments

Comments

@rishabhpoddar
Copy link
Contributor

The issue with using cookie store on the frontend in header based auth is that those cookies are not secure. So during page loads, those can be sent over the network even with http.

Therefore, i think we should use localstorage by default. And then only use cookie storage if user has set frontendCookieDomain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant