Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Streamline use of custom end-markers #22

Open
seemantk opened this issue Apr 26, 2017 · 1 comment
Open

Enhancement Request: Streamline use of custom end-markers #22

seemantk opened this issue Apr 26, 2017 · 1 comment

Comments

@seemantk
Copy link

Hi @susielu! Thank you for creating d3-annotation, it's lovely.

I was curious about the arrowhead/circle options. It looks like the builder runs for every connector that has a marker.

Was wondering if you'd considered SVG's native marker element which knows how to attach itself to the end of a line, and so by default scales itself to the stroke-width and rotates itself to match the line.

Thus, the arrow marker paths would go into a <marker> element in <defs>, and get called using the marker-end attribute.

Sorry if you've already looked and discarded this.

@susielu
Copy link
Owner

susielu commented Apr 27, 2017

Oh wow, that looks great. I didn't know of that element in SVG. I will take a look thanks @seemantk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants