Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some color #195

Open
braebo opened this issue Oct 22, 2024 · 8 comments · May be fixed by #294
Open

adding some color #195

braebo opened this issue Oct 22, 2024 · 8 comments · May be fixed by #294
Labels
enhancement New feature or request pkg:add sv add

Comments

@braebo
Copy link
Member

braebo commented Oct 22, 2024

Are you guys opposed to adding some color? If used well, a boost to the look/feel can also improve readability. I'd be happy to take a stab if it makes sense.

The astro and nuxt cli's are nice examples (though I prefer the former):

Screenshot 2024-10-21 at 9 01 16 PM
@manuel3108
Copy link
Member

Like the idea, but code-wise it's a mess. See #206

@benmccann
Copy link
Member

benmccann commented Oct 22, 2024

The astro one looks pretty nice to me. I wonder if we can do a similar one, but with svelte orange/red

@manuel3108
Copy link
Member

Waiting for tj/commander.js#2251 to properly implement this.

@manuel3108
Copy link
Member

I tried out the PR locally, here is what i got. Also if anyone want's to play around with it that has a more visual eye, here is a small repro (pnpm i && node .)

pretty basic
image

bit more fancy (bold command, dimmed options)
image

personal preference:
image

@brunnerh
Copy link
Member

brunnerh commented Nov 10, 2024

The headings style seems way too intense to me.
Would go with something less drastic along the lines of:

image

Also, could be tinted a bit more orange
image
(This would be the svelte.dev accent color in dark mode - #f96743)

@manuel3108
Copy link
Member

I do agree with the headlines - this was based on the previous preference of the astro cli.
As for the color, we are in a console environment with only a pretty limited amount of supported output colors. So i think this is the best we can get if we want it to stay sveltish

@brunnerh
Copy link
Member

Most modern terminals support 24bit colors, though I don't know how those not supporting it would behave.

@benmccann
Copy link
Member

Hard to say from just a screenshot and maybe I'd feel differently after playing around with it, but I kind of liked the astro-style headings. All caps like Nuxt isn't too bad either

@manuel3108 manuel3108 linked a pull request Nov 12, 2024 that will close this issue
@manuel3108 manuel3108 added enhancement New feature or request pkg:add sv add labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:add sv add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants