Redirect from hooks.js doesn't work anymore after breaking changes

[steffenstolze]

We use a handle function in hooks/index.js to redirect a user to /account/onboarding when certain criteria matched and the user actively enters a url in the browser.

import { sequence } from '@sveltejs/kit/hooks';
import { parse } from 'cookie';

export const handle = sequence(redirectAuthenticatedUserIfOnboardingNotCompleted);

/** @type {import('@sveltejs/kit').Handle} */
async function redirectAuthenticatedUserIfOnboardingNotCompleted({ event, resolve }) {
	const cookies = event.request.headers.get('cookie');

	//no cookies means unauthenticated user - do nothing.
	if (!cookies) return await resolve(event);

	//parse and save cookie values to locals, so you can use them in endpoints
	const { onboarding_incompleted, access_token } = parse(cookies);
	event.locals.onboarding_completed = !onboarding_incompleted;
	event.locals.access_token = access_token;

	//if an authenticated user, who has not finished onboarding, tries to load any page that's not onboarding, redirect to onboarding
	if (access_token && onboarding_incompleted && event.url.pathname != '/account/onboarding') {
		return new Response('Redirect', { status: 303, headers: { Location: '/account/onboarding' } });
	}

	return await resolve(event);
}

if a user now clicks an <a> tag to / the route will not change but we get an error:

if I remove the redirect line, everything works fine.

How can we fix this? Thanks!

[Rich-Harris]

#6112