-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Renamed MISTRALAI to MISTRAL everywhere #231
[Breaking] Renamed MISTRALAI to MISTRAL everywhere #231
Conversation
I doubt too many people would use Mistral models, but I hope they can also adjust this in their env vars. Although I see they need to be aware of the change. In their docs it is called MISTRAL_API_KEY: https://docs.mistral.ai/getting-started/quickstart/ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 91.93% 91.98% +0.04%
==========================================
Files 47 47
Lines 4601 4640 +39
==========================================
+ Hits 4230 4268 +38
- Misses 371 372 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@Sixzero Could you please add a new section at the top of the changelog record that is a breaking change and explain it there? See past examples. The idea is to make it stand out / make it easy to see when some breaking changes happened |
Good idea! |
Added the legacy support. On a sidenote: |
Awesome! Thank you! I've just added the note to the changelog as a breaking change. |
MISTRALAI I think was deceptive, as everywhere out there it is called MISTRAL_API_KEY.