Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Renamed MISTRALAI to MISTRAL everywhere #231

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

Sixzero
Copy link
Collaborator

@Sixzero Sixzero commented Nov 5, 2024

MISTRALAI I think was deceptive, as everywhere out there it is called MISTRAL_API_KEY.

@Sixzero
Copy link
Collaborator Author

Sixzero commented Nov 5, 2024

I doubt too many people would use Mistral models, but I hope they can also adjust this in their env vars. Although I see they need to be aware of the change.

In their docs it is called MISTRAL_API_KEY: https://docs.mistral.ai/getting-started/quickstart/

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.98%. Comparing base (bfc8833) to head (b91160d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/llm_openai_schema_defs.jl 50.00% 1 Missing ⚠️
src/user_preferences.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   91.93%   91.98%   +0.04%     
==========================================
  Files          47       47              
  Lines        4601     4640      +39     
==========================================
+ Hits         4230     4268      +38     
- Misses        371      372       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@svilupp
Copy link
Owner

svilupp commented Nov 6, 2024

@Sixzero Could you please add a new section at the top of the changelog record that is a breaking change and explain it there? See past examples. The idea is to make it stand out / make it easy to see when some breaking changes happened

src/user_preferences.jl Outdated Show resolved Hide resolved
@Sixzero
Copy link
Collaborator Author

Sixzero commented Nov 7, 2024

Good idea!

@Sixzero Sixzero changed the title Renamed MISTRALAI to MISTRAL everywhere [BREAKING] Renamed MISTRALAI to MISTRAL everywhere Nov 7, 2024
@Sixzero Sixzero changed the title [BREAKING] Renamed MISTRALAI to MISTRAL everywhere [Breaking] Renamed MISTRALAI to MISTRAL everywhere Nov 7, 2024
@Sixzero
Copy link
Collaborator Author

Sixzero commented Nov 8, 2024

Added the legacy support.

On a sidenote:
Actually AISH.jl couldn't generate the solution, had to do it manually, because the file is 55k character long and most LLMs can only generate 8000 tokens as output, so for long files I guess "Instant Apply" should switch back to some legacy diffing solution.

CHANGELOG.md Show resolved Hide resolved
@svilupp svilupp merged commit aa481ab into svilupp:main Nov 18, 2024
3 checks passed
@svilupp
Copy link
Owner

svilupp commented Nov 18, 2024

Awesome! Thank you! I've just added the note to the changelog as a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants