Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplication in navigation #89

Open
emielvanrijn1 opened this issue Jan 18, 2019 · 0 comments
Open

Duplication in navigation #89

emielvanrijn1 opened this issue Jan 18, 2019 · 0 comments
Labels
refactor

Comments

@emielvanrijn1
Copy link

Currently there is a lot of duplication in both desktop/tablet and mobile navigation. We should deduplicate this by having a general Navigation component, which does all the work, and then chooses either navbar or mobilenavbar.
@Riscky Riscky added enhancement Proposes (changes to) a feature refactor and removed enhancement Proposes (changes to) a feature labels Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Riscky @emielvanrijn1