Use ParameterMessageInterpolation #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frantuma
requested changes
Nov 4, 2024
There was a problem hiding this comment.
This looks ok but please rename commit adding ref to related ticket swagger-api/swagger-codegen/issues/12448
Just as a note for future reference, the other option instead of adding ParameterMessageInterpolator is adding EL implementation to dependencies. This would mean downgrade el-api to 5.x for jakarta, and is currently not needed as no EL expression is used in validation annotations.
frantuma
force-pushed
the
fix-Java-missing-interpolation-dpenedency
branch
from
877e4d9 to
b358114
Compare
micryc
force-pushed
the
fix-Java-missing-interpolation-dpenedency
branch
from
b358114 to
118101d
Compare
…ation to get rid of hibernate error with missing dependency
micryc
force-pushed
the
fix-Java-missing-interpolation-dpenedency
branch
from
118101d to
e0bc7ff
Compare
frantuma
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs-swagger-api/swagger-codegen#12448
Use ParameterMessageInterpolation to get rid of error with hibernate missing EL dependency