Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in 07-github do not correspond to text #1033

Open
scmbradley opened this issue Oct 28, 2024 · 7 comments
Open

Images in 07-github do not correspond to text #1033

scmbradley opened this issue Oct 28, 2024 · 7 comments
Assignees
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors

Comments

@scmbradley
Copy link

What is the problem?

The text of the 07-github page refers to Alfredo Linguine's recipes repo, but the images in the page appear to be about user kekoziar's planets repo. Since the rest of the guide up to this point has been about recipes, the images should be adjusted to match.

Location of problem (optional)

https://swcarpentry.github.io/git-novice/07-github.html

@martinosorb
Copy link
Contributor

Indeed, I think the correct screenshots have never been taken. Would you have time to submit a PR for this? No problem if not.

@martinosorb martinosorb added help wanted Looking for Contributors good first issue Good issue for first-time contributors labels Oct 28, 2024
@scmbradley
Copy link
Author

Yeah sure I can have a go. It'll be a few days before I get some time. Would the idea be to just take screenshots of GitHub from my user account at the relevant points of doing the steps in the page?

@martinosorb
Copy link
Contributor

That would be fine, yes. Make sure no other personal info is visible. Thank you so much! If you change your mind please let us know so we can assign it to someone else.

@CFGrote
Copy link

CFGrote commented Nov 22, 2024

I just stumbled across this, too. @scmbradley , are you working on a PR? I can offer my help if needed.

@martinosorb
Copy link
Contributor

@CFGrote it's been a few weeks, so if you want to do it I'm sure it'll be fine. Thanks for offering.

@scmbradley
Copy link
Author

@CFGrote hi, yes please. My son was born a little early, shortly after I opened this issue, so I have a lot less time than I expected.

@CFGrote
Copy link

CFGrote commented Nov 23, 2024

OK,Im on it. Good luck @scmbradley and all best for your newborn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors
Projects
None yet
Development

No branches or pull requests

3 participants