Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change error display length on all line instead of first char #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rush93
Copy link

@rush93 rush93 commented Aug 31, 2022

get the line size of the document to display error on full line

fix #6

@juanrgm
Copy link
Member

juanrgm commented Sep 18, 2022

Thanks for your merge request!

What happen if you have hundreds or thousands of errors? The async function vscode.workspace.openTextDocument will be called a lot of times.

Possible bottleneck?

@rush93
Copy link
Author

rush93 commented Sep 21, 2022

Thanks for your merge request!

What happen if you have hundreds or thousands of errors? The async function vscode.workspace.openTextDocument will be called a lot of times.

Possible bottleneck?

What do you suggest ?
add a limit of call to openTextDocument ?
or not calling openTextDocument and set the end char to 9999 and let vscode stop at the right char ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors are not shown properly
3 participants