Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all special render logic to helper functions #95

Open
wainola opened this issue Oct 17, 2023 · 1 comment
Open

Move all special render logic to helper functions #95

wainola opened this issue Oct 17, 2023 · 1 comment

Comments

@wainola
Copy link
Contributor

wainola commented Oct 17, 2023

Detail view and explorer table have some conditional logic for the values to be rendered. Some of this logic is in the markup itself and some is some helper functions. Move all to helpers functions and provide unit test for those

Implementation details

  • move all necessary logic that is on markup to helper functions
  • create unit test for all the helper functions and update the current ones if necessary

Testing details

  • testing must pass locally

Acceptance Criteria

  • Explorer UI should render the information correclty
@wainola wainola added this to the Cycle 3 milestone Oct 17, 2023
@wainola wainola self-assigned this Oct 17, 2023
@itsbobbyzzz168
Copy link

Mak will help reorg the explorer UI into 0.1.0 / 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants