Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid without storage info macro #99

Merged
merged 4 commits into from
May 9, 2023
Merged

fix: avoid without storage info macro #99

merged 4 commits into from
May 9, 2023

Conversation

mpetrun5
Copy link
Contributor

Remove without storage info substrate macro.

Closes: #94

@mpetrun5 mpetrun5 requested review from freddyli7 and tolak April 24, 2023 10:15
@pesco
Copy link

pesco commented Apr 24, 2023

Looks good, but note that without_storage_info is also used on the access-segregator, basic-fee-handler, and fee-handler-router pallets, so #94 applies to them as well, even if they were not explicitly called out in the report.

@MakMuftic MakMuftic requested a review from pesco May 2, 2023 12:48
@MakMuftic MakMuftic merged commit abd6db1 into main May 9, 2023
@MakMuftic MakMuftic mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolak tolak tolak approved these changes

@pesco pesco pesco approved these changes

@freddyli7 freddyli7 Awaiting requested review from freddyli7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid pallet::without_storage_info in Production Code
4 participants
@mpetrun5 @pesco @tolak @MakMuftic