Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is not notified if the transfer fails #116

Open
LyonSsS opened this issue Feb 26, 2024 · 6 comments
Open

User is not notified if the transfer fails #116

LyonSsS opened this issue Feb 26, 2024 · 6 comments

Comments

@LyonSsS
Copy link

LyonSsS commented Feb 26, 2024

Severity: Medium | Priority: Medium

Note: If there is a failure in the transfer flow, the user will not going to get notified.

STR:

  1. Create an E2E flow from EVM to Substrate.
  2. Pass an incompatible Substrate address.
  3. Finalize transfer flow.
  4. Transfer fails at execution on substrate.

Exp: The user to be informed somehow that his transfer failed at maturity.
Act: The user has no clue, other than the scan that the transfer failed.

image

@MakMuftic
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @Lykhoyda @mpetrunic @wainola

@wainola
Copy link
Contributor

wainola commented Mar 4, 2024

@mpetrunic do we need some design updates for this?

@mpetrunic
Copy link
Member

@MakMuftic @LyonSsS I think this is out of scope for 0.x as we would need indexer feature for that.

@LyonSsS What is the incompatible substrate address?

@MakMuftic
Copy link
Contributor

We have this already @mpetrunic, also added to the SDK here.

It doesn't provide a detailed reason of failure, but returns transfer state: 'pending' | 'executed' | 'failed'

@LyonSsS
Copy link
Author

LyonSsS commented Mar 6, 2024

In this scenario I profited about the UI design to send EVM address for Substrate destination, which failed. Scope was to fail execution ... but it can be replicated with Relayer Issues OR not having enough funds on destination to execute proposal ... so the flow has potential.
In terms of UI, this seems like an improvement and we can scope it for next iteration. Might move it to a feature this instead of a bug. @mpetrunic

@mpetrunic
Copy link
Member

I would move it into new feature for next cycle as we need different designs for that^^

@mpetrunic mpetrunic removed the Bug label Mar 6, 2024
@MakMuftic MakMuftic removed this from the Cycle 2 🐲 milestone Apr 3, 2024
@MakMuftic MakMuftic added this to the Cycle 3 🦘 milestone Apr 12, 2024
@MakMuftic MakMuftic removed this from the Cycle 3 🦘 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants