Amount to receive is not correct displayed when using the percentage fee handler #192
Comments
Merged
|
This issue is visible only if the fee is percentage ( lower and upper bound is fine) |
|
Verified on PR preview build #196 - the issue is fixed now |
|
@wainola why is this re opnened |
|
Retested on #196 (review) |
wainola
added a commit
that referenced
this issue
Jun 11, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description Fixes displayed amount to receive due to double subtraction over the already subtracted value <!--- Describe your changes in detail --> ## Related Issue Or Context <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Otherwise, describe context and motivation for change here --> Closes: #192 ## How Has This Been Tested? Testing details. <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have ensured that all acceptance criteria (or expected behavior) from issue are met - [ ] I have updated the documentation locally and in sygma-docs. - [ ] I have added tests to cover my changes. - [ ] I have ensured that all the checks are passing and green, I've signed the CLA bot --------- Co-authored-by: Saad Ahmed Siddiqui <[email protected]> Co-authored-by: Anton Lykhoyda <[email protected]> Co-authored-by: Filip Štoković <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
STR:
Exp: The fee should be 1 and the amount to transfer should be 11.
Act: The fee is 1 and the amount to be transferred is 10.
The issue is also found when using Source as Substrate and using a value in the lower bound
The text was updated successfully, but these errors were encountered: