Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a substrate TX is canceled from polkadot.js app, then the transfer button is no longer usable #193

Closed
LyonSsS opened this issue May 8, 2024 · 1 comment · Fixed by #195
Closed

If a substrate TX is canceled from polkadot.js app, then the transfer button is no longer usable #193

LyonSsS opened this issue May 8, 2024 · 1 comment · Fixed by #195
Assignees
@wainola
Labels
Bug Priority: P2
Milestone
Cycle 3 🦘

Comments

@LyonSsS
Copy link

LyonSsS commented May 8, 2024

Context: If a user cancels the transfer tx from polkadot.js wallet, then he can still be able to re trigger the transfer button and see another pop-up proc to sign a new TX. Currently this is not working.

Cancel_Substrate_Tx
@LyonSsS LyonSsS mentioned this issue May 8, 2024
Merged
@wainola wainola self-assigned this May 9, 2024
@MakMuftic MakMuftic added this to the Cycle 3 🦘 milestone May 9, 2024
@wainola wainola mentioned this issue May 12, 2024
Merged
9 tasks
@LyonSsS
Copy link
Author

LyonSsS commented May 21, 2024

Tested on PR #195 - this is now fixed
image

@LyonSsS LyonSsS closed this as completed May 21, 2024
wainola added a commit that referenced this issue May 22, 2024
@wainola
fix: handling transfer cancellation on substrate (#195)
6ce25cb 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

Handles user cancelation on substrate transfer

## Related Issue Or Context

<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Otherwise, describe context and motivation for change here -->

Closes: #193 

## How Has This Been Tested? Testing details.

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have ensured that all acceptance criteria (or expected behavior)
from issue are met
- [ ] I have updated the documentation locally and in sygma-docs.
- [ ] I have added tests to cover my changes.
- [ ] I have ensured that all the checks are passing and green, I've
signed the CLA bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wainola wainola

Labels
Bug Priority: P2
Projects
None yet
Milestone
Cycle 3 🦘
Development

Successfully merging a pull request may close this issue.

fix: handling transfer cancellation on substrate sygmaprotocol/sygma-widget
3 participants
@wainola @MakMuftic @LyonSsS