Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated sass notation when using more recent gems than GitHub page #458

Closed
sylhare opened this issue Aug 9, 2024 · 0 comments · Fixed by #460
Closed

Deprecated sass notation when using more recent gems than GitHub page #458

sylhare opened this issue Aug 9, 2024 · 0 comments · Fixed by #460
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@sylhare
Copy link
Owner

sylhare commented Aug 9, 2024

Example in the build gem workflow here:

    ╷
7  │ ┌   @media screen and (max-width: $sm-break) {
8  │ │     overflow-x: auto;
9  │ │   }
   │ └─── nested rule
10 │     padding-bottom: 3px;
   │     ^^^^^^^^^^^^^^^^^^^ declaration
   ╵
    /home/runner/work/Type-on-Strap/Type-on-Strap/_sass/external/_katex.scss 10:3  @import
    type-on-strap.scss 12:9                                                        @import
    /home/runner/work/Type-on-Strap/Type-on-Strap/assets/css/main.scss 1:9         root stylesheet
DEPRECATION WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

This is linked to custom sass styling for Katex, let's try to fix it without impacting the theme running with the GitHub page gem which uses an older version for sass.

@sylhare sylhare added the dependencies Pull requests that update a dependency file label Aug 9, 2024
@sylhare sylhare self-assigned this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant