Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

POC for defunct route options #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dantleech
Copy link
Member

The aim of this POC PR is to explore the possiblity passing options to the defunct route handlers - the use case being allowing the redirect HTTP code to be passed to the adapter which creates the redirect route.

Intitially I tried to avoid BC breaks, but the requirement to add $options to the handleDefunctRoutes method breaks any chance of this. The role of the new ConfigurableInterface is therefore up for debate.

@wouterj
Copy link
Member

wouterj commented Aug 23, 2015

Do you think there are going to be more settings than the HTTP code? Otherwise, I'd prefer to not use the options resolver and just pass a config value to the constructor of LeaveRedirectDefunctRouteHandler.

@wouterj wouterj added this to the 1.1 milestone Aug 23, 2015
@dantleech
Copy link
Member Author

There was a reason -- iirc it might have been that the HTTP code is not a DI config, is is metadata.

@wouterj
Copy link
Member

wouterj commented Oct 28, 2015

I propose to remove the ConfigurableInterface and add a new BC break. However, the current PR doesn't do anything, as the http code option isn't used anywhere in the code.

@wouterj wouterj modified the milestones: 2.0, 1.1 Mar 30, 2016
@ElectricMaxxx ElectricMaxxx modified the milestones: 2.1, 2.0 Nov 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants