Add AuthUrlAction to override UrlAction for SSO auth
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 80.58% 80.84% +0.26%
==========================================
Files 25 25
Lines 2941 2949 +8
==========================================
+ Hits 2370 2384 +14
+ Misses 500 496 -4
+ Partials 71 69 -2
Continue to review full report in Codecov by Sentry.
|
synfinatic
force-pushed
the
multiple-sso-sessions
branch
2 times, most recently
from
2804752 to
5c4e0ca
Compare
synfinatic
force-pushed
the
multiple-sso-sessions
branch
from
5c4e0ca to
c4309d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically reverts #491 and goes back to unique Firefox containers for each SSO provider/AWS SSO instance. The AuthUrlAction does allow you to pick a single SSO instance to use your default browser via
opento re-use the existing session cookies you might already have.Fixes: #524