Welcome to aioaria2 Discussions! #3

synodriver · 2021-03-08T11:00:10Z

synodriver
Mar 8, 2021
Maintainer

👋 Welcome!

We’re using Discussions as a place to connect with other members of our community. We hope that you:

Ask questions you’re wondering about.
Share ideas.
Engage with other community members.
Welcome others and are open-minded. Remember that this is a community we
build together 💪.

To get started, comment below with an introduction of yourself and tell us about what you do with this community.

adekmaulana · 2021-04-18T20:40:18Z

adekmaulana
Apr 18, 2021

Hello, thanks for this module, it's me again.

can you catch exception in here to close the self._client_session if exceptions occurs and re raise it, because sometimes ws failed to connect e.g Connection refused

2021-04-18T20:19:56.413920+00:00 app[caligo.1]:   ERROR    |  asyncio      |  Task exception was never retrieved
2021-04-18T20:19:56.413933+00:00 app[caligo.1]: future: <Task finished name='Task-171' coro=<Aria2.on_started() done, defined at /home/caligo/caligo/modules/aria2.py:399> exception=ClientConnectorError(ConnectionKey(host='localhost', port=8443, is_ssl=True, ssl=None, proxy=None, proxy_auth=None, proxy_headers_hash=None), ConnectionRefusedError(111, 'Connection refused'))>
2021-04-18T20:19:56.413934+00:00 app[caligo.1]: Traceback (most recent call last):
2021-04-18T20:19:56.413935+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aiohttp/connector.py", line 969, in _wrap_create_connection
2021-04-18T20:19:56.413935+00:00 app[caligo.1]:     return await self._loop.create_connection(*args, **kwargs)  # type: ignore  # noqa
2021-04-18T20:19:56.413936+00:00 app[caligo.1]:   File "uvloop/loop.pyx", line 2017, in create_connection
2021-04-18T20:19:56.413937+00:00 app[caligo.1]:   File "uvloop/loop.pyx", line 1994, in uvloop.loop.Loop.create_connection
2021-04-18T20:19:56.413937+00:00 app[caligo.1]: ConnectionRefusedError: [Errno 111] Connection refused
2021-04-18T20:19:56.413938+00:00 app[caligo.1]: 
2021-04-18T20:19:56.413938+00:00 app[caligo.1]: The above exception was the direct cause of the following exception:
2021-04-18T20:19:56.413939+00:00 app[caligo.1]: 
2021-04-18T20:19:56.413939+00:00 app[caligo.1]: Traceback (most recent call last):
2021-04-18T20:19:56.413939+00:00 app[caligo.1]:   File "/home/caligo/caligo/modules/aria2.py", line 401, in on_started
2021-04-18T20:19:56.413939+00:00 app[caligo.1]:     self.client = await Aria2WebSocket.init(self)
2021-04-18T20:19:56.413940+00:00 app[caligo.1]:   File "/home/caligo/caligo/modules/aria2.py", line 73, in init
2021-04-18T20:19:56.413940+00:00 app[caligo.1]:     client = await aioaria2.Aria2WebsocketTrigger.new(url=protocol)
2021-04-18T20:19:56.413940+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aioaria2/client.py", line 791, in new
2021-04-18T20:19:56.413941+00:00 app[caligo.1]:     self.client_session: aiohttp.ClientWebSocketResponse = await self._client_session.ws_connect(self.url,
2021-04-18T20:19:56.413941+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aiohttp/client.py", line 754, in _ws_connect
2021-04-18T20:19:56.413942+00:00 app[caligo.1]:     resp = await self.request(
2021-04-18T20:19:56.413942+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aiohttp/client.py", line 520, in _request
2021-04-18T20:19:56.413942+00:00 app[caligo.1]:     conn = await self._connector.connect(
2021-04-18T20:19:56.413942+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aiohttp/connector.py", line 535, in connect
2021-04-18T20:19:56.413942+00:00 app[caligo.1]:     proto = await self._create_connection(req, traces, timeout)
2021-04-18T20:19:56.413943+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aiohttp/connector.py", line 892, in _create_connection
2021-04-18T20:19:56.413943+00:00 app[caligo.1]:     _, proto = await self._create_direct_connection(req, traces, timeout)
2021-04-18T20:19:56.413943+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aiohttp/connector.py", line 1051, in _create_direct_connection
2021-04-18T20:19:56.413943+00:00 app[caligo.1]:     raise last_exc
2021-04-18T20:19:56.413944+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aiohttp/connector.py", line 1020, in _create_direct_connection
2021-04-18T20:19:56.413944+00:00 app[caligo.1]:     transp, proto = await self._wrap_create_connection(
2021-04-18T20:19:56.413944+00:00 app[caligo.1]:   File "/opt/venv/lib/python3.9/site-packages/aiohttp/connector.py", line 975, in _wrap_create_connection
2021-04-18T20:19:56.413944+00:00 app[caligo.1]:     raise client_error(req.connection_key, exc) from exc
2021-04-18T20:19:56.413945+00:00 app[caligo.1]: aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host localhost:8443 ssl:default [Connection refused]
2021-04-18T20:19:56.414049+00:00 app[caligo.1]:   INFO     |  Bot          |  Idling...
2021-04-18T20:22:28.367361+00:00 app[caligo.1]:   ERROR    |  asyncio      |  Unclosed client session
2021-04-18T20:22:28.367372+00:00 app[caligo.1]: client_session: <aiohttp.client.ClientSession object at 0x7fce64b651f0>

I have a work arounds for that connection refuse error using tenacity, but the unclose client session is still there.
and i can't close it myself, it was a protected member and the client itself it hasn't been initialize... because of that exception

2021-04-18T20:22:46.785476+00:00 app[caligo.1]:   INFO     |  System       |  Bot restarted in 5 sec
2021-04-18T20:22:46.999384+00:00 app[caligo.1]:   INFO     |  Bot          |  Bot is ready
2021-04-18T20:22:47.653013+00:00 app[caligo.1]:   ERROR    |  asyncio      |  Unclosed client session
2021-04-18T20:22:47.653022+00:00 app[caligo.1]: client_session: <aiohttp.client.ClientSession object at 0x7f5847a53a30>
2021-04-18T20:22:47.653608+00:00 app[caligo.1]:   INFO     |  Bot          |  Idling...

8 replies

adekmaulana Apr 19, 2021

thank you

Normally,catch the Aria2rpcException for that is enough,besides,I also released a rcversion on pypi which have some new feature

Yes, i saw it in the code. will try the rc version Thanks!

synodriver Apr 19, 2021
Maintainer Author

thank you

Normally,catch the Aria2rpcException for that is enough,besides,I also released a rcversion on pypi which have some new feature

Yes, i saw it in the code. will try the rc version Thanks!

I will be able to release a stable version if no client_session-related bugs happen. Besides, this also seems to have an impact with ssl

adekmaulana Apr 19, 2021

thank you

Normally,catch the Aria2rpcException for that is enough,besides,I also released a rcversion on pypi which have some new feature

Yes, i saw it in the code. will try the rc version Thanks!

I will be able to release a stable version if no client_session-related bugs happen. Besides, this also seems to have an impact with ssl

It's fixed btw 😃 no more unclose client_session again even though it was failing at first attempt

2021-04-19T12:33:03.777530+00:00 app[caligo.1]:   DEBUG    |  Bot          |  Dispatching event 'load' with data ()
2021-04-19T12:33:07.912026+00:00 app[caligo.1]:   DEBUG    |  Bot          |  Dispatching event 'start' with data (1618835587911680,)
2021-04-19T12:33:07.994240+00:00 app[caligo.1]:   INFO     |  System       |  Bot restarted in 7 sec
2021-04-19T12:33:08.224286+00:00 app[caligo.1]:   INFO     |  Bot          |  Bot is ready
2021-04-19T12:33:08.224473+00:00 app[caligo.1]:   DEBUG    |  Bot          |  Dispatching event 'started' with data ()
2021-04-19T12:33:08.224779+00:00 app[caligo.1]:   DEBUG    |  Aria2WS      |  Starting call to 'caligo.modules.aria2.Aria2.on_started', this is the 1st time calling it.
2021-04-19T12:33:10.835981+00:00 app[caligo.1]:   DEBUG    |  Aria2WS      |  Starting call to 'caligo.modules.aria2.Aria2.on_started', this is the 2nd time calling it.

synodriver Apr 19, 2021
Maintainer Author

It's fixed btw 😃 no more unclose client_session again even though it was failing at first attempt

That's great! Although I never encounter this problem but still thanks for letting me know this potential defect since I have been using it in my scrapy and fastapi-related project for a long time.

adekmaulana Apr 19, 2021

That's great! Although I never encounter this problem but still thanks for letting me know this potential defect since I have been using it in my scrapy and fastapi-related project for a long time.

The problem came since 15/16 days a go, i thought it was from using https but changing to the default http the problem still came everytime i restart the bot, it may be from heroku server, because i was using it there. but everything is good now, Thanks again!

synodriver · 2021-04-19T06:53:36Z

synodriver
Apr 19, 2021
Maintainer Author

Also I have readme.md translated.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Welcome to aioaria2 Discussions! #3

{{title}}

Replies: 2 comments 8 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Welcome to aioaria2 Discussions! #3

synodriver Mar 8, 2021 Maintainer

👋 Welcome!

Replies: 2 comments · 8 replies

adekmaulana Apr 18, 2021

adekmaulana Apr 19, 2021

synodriver Apr 19, 2021 Maintainer Author

adekmaulana Apr 19, 2021

synodriver Apr 19, 2021 Maintainer Author

adekmaulana Apr 19, 2021

synodriver Apr 19, 2021 Maintainer Author

synodriver
Mar 8, 2021
Maintainer

Replies: 2 comments 8 replies

adekmaulana
Apr 18, 2021

synodriver Apr 19, 2021
Maintainer Author

synodriver Apr 19, 2021
Maintainer Author

synodriver
Apr 19, 2021
Maintainer Author