Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 77 - TwoList and Link widgets #78

Closed
wants to merge 16 commits into from

Conversation

Franek75
Copy link
Contributor

PR Details

New TwoList widget and Link widgets

Description

TwoList widget has been implemented to cover the TwoList component
Link widget has been implemented to cover links that appear inside the TwoList

Both are new WOs.

Related Issue

#77

Motivation and Context

It enabled other projects to use these widgets in their e2e tests

How Has This Been Tested

Tested in the project's e2e tests

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each widget)
  • I have added tests to cover my changes (at least 1 spec for each widget with the same coverage as the master branch)
  • All tests (new and existing) passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • Add the issue into the right project with the proper status (In progress)

@Franek75 Franek75 self-assigned this Jul 18, 2024
@Franek75 Franek75 linked an issue Jul 18, 2024 that may be closed by this pull request
@Franek75 Franek75 added the enhancement New feature or request label Jul 18, 2024
src/widgets/two-list.ts Outdated Show resolved Hide resolved
src/widgets/two-list.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@Franek75 Franek75 changed the base branch from main to 1.10.x July 19, 2024 06:41
@Franek75 Franek75 closed this Jul 19, 2024
@Franek75
Copy link
Contributor Author

PR closed (declined) as it should be created against 1.10.x branch, not against main

@Franek75 Franek75 deleted the feature-77-twolist-widget branch July 19, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the TwoList widget
3 participants