Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add worksheet_range_ref for calamine::Xls and calamine::Ods #383

Closed
lucatrv opened this issue Dec 13, 2023 · 2 comments · Fixed by #414
Closed

Please add worksheet_range_ref for calamine::Xls and calamine::Ods #383

lucatrv opened this issue Dec 13, 2023 · 2 comments · Fixed by #414

Comments

@lucatrv
Copy link
Contributor

lucatrv commented Dec 13, 2023

As in subject, release 0.23.0 added worksheet_range_ref for calamine::Xlsx but not for calamine::Xls and calamine::Ods.
@dimastbk
Copy link
Contributor

Xls/Ods don't support lazy iteration, see #370 (comment)

@lucatrv
Copy link
Contributor Author

lucatrv commented Dec 20, 2023

Thanks for the info, I didn't know. Maybe I should keep this issue open because it would be useful to document this, for instance here.

lucatrv added a commit to lucatrv/calamine that referenced this issue Mar 1, 2024
@lucatrv
docs: add note for Xlsx::worksheet_range_ref
9c96e5e 
Closes tafia#383
@lucatrv lucatrv mentioned this issue Mar 1, 2024
Merged
@tafia tafia closed this as completed in #414 Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add note for Xlsx::worksheet_range_ref lucatrv/calamine
2 participants
@dimastbk @lucatrv