-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement handling of merged cells for .xlsx workbooks #226
base: master
Are you sure you want to change the base?
Conversation
It seems that my implementation fails the |
Attempted to figure out whats going wrong here, but this is beyond me. I'm going to leave my findings here in case it proves any help to you. It looks like your dimensions for merge is Dimensions { start: (0,0), end: (2,6) }
Dimensions { start: (0,7), end: (2,12) } but the range you are getting from sparse is |
Thanks for taking a look into this @Fuzen-py. I think that the issue here was my usage of subscripting for reading/writing This does not, however, resolve the test failure. I still need to add a proper test for merge cells, but I would like to suggest that the |
It doesn't appear to explicitly test the functionality of merged cells, its just part of the process of the workbook. I don't think that writing a specific test just for merged cells in addition to the current test is bad though. |
Right, but that's what I'm actually suggesting could be an issue. The test implicitly relies on merged cells working properly after this PR, whereas ideally the test will fail/succeed regardless of whether or not the implementation of merged cells is correct. |
This PR adds handling for the
mergeCells
tag by parsing it and then editing the createdRange
before returning it. Perhaps there is a better way to go about this, but operating on theRange
rather than theVec
of cells seemed like a better option.