Adding in ability to read merge cells from xls and xlsx files. #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magackame
force-pushed
the
tspayne87/merge-cells
branch
from
b4158e2 to
d241337
Compare
|
Thanks for the PR, I've made a few comments. |
tafia
requested changes
May 24, 2024
src/xls.rs
Outdated
| @@ -141,7 +141,7 @@ pub struct XlsOptions { | |||
|
|
|||
| /// A struct representing an old xls format file (CFB) | |||
| pub struct Xls<RS> { | |||
| sheets: BTreeMap<String, (Range<Data>, Range<String>)>, | |||
| sheets: BTreeMap<String, (Range<Data>, Range<String>, Vec<Dimensions>)>, | |||
There was a problem hiding this comment.
At some point we will probably need to have some struct with property names.
There was a problem hiding this comment.
Is something like that satisfactory?
struct SheetData {
range: Range<Data>,
formula: Range<String>,
merge_cells: Vec<Dimensions>,
}
magackame
force-pushed
the
tspayne87/merge-cells
branch
from
d241337 to
afe3dff
Compare
magackame
force-pushed
the
tspayne87/merge-cells
branch
from
afe3dff to
6b25dbc
Compare
tafia
approved these changes
May 27, 2024
|
Thanks! |
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305 based on rebase of #307