fix(temporary): duplicates and detaching query parameters

tailflow · Mar 30, 2021 · 56ecd05 · 56ecd05
1 parent c971ecb
commit 56ecd05
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "@tailflow/laravel-orion",
-	"version": "1.0.0",
+	"version": "1.0.1",
 	"description": "Typescript SDK for Laravel Orion",
 	"keywords": [
 		"laravel orion",

diff --git a/src/drivers/default/relations/belongsToMany.ts b/src/drivers/default/relations/belongsToMany.ts
@@ -24,7 +24,7 @@ export class BelongsToMany<
 		const response = await this.httpClient.request(
 			`/attach`,
 			HttpMethod.POST,
-			{ duplicates },
+			{ duplicates: duplicates ? 1 : 0 },
 			{
 				resources: keys,
 			}
@@ -40,7 +40,7 @@ export class BelongsToMany<
 		const response = await this.httpClient.request(
 			`/attach`,
 			HttpMethod.POST,
-			{ duplicates },
+			{ duplicates: duplicates ? 1 : 0 },
 			{ resources }
 		);
 
@@ -67,7 +67,7 @@ export class BelongsToMany<
 		const response = await this.httpClient.request(
 			`/sync`,
 			HttpMethod.PATCH,
-			{ detaching },
+			{ detaching: detaching ? 1 : 0 },
 			{
 				resources: keys,
 			}
@@ -83,7 +83,7 @@ export class BelongsToMany<
 		const response = await this.httpClient.request(
 			`/sync`,
 			HttpMethod.PATCH,
-			{ detaching },
+			{ detaching: detaching ? 1 : 0 },
 			{ resources }
 		);
 

diff --git a/tests/integration/drivers/default/relations/belongsToMany.test.ts b/tests/integration/drivers/default/relations/belongsToMany.test.ts
@@ -39,7 +39,7 @@ describe('BelongsToMany tests', () => {
 		expect(attachResult.attached).toStrictEqual([2, 5, 7]);
 
 		const requests = server.pretender.handledRequests;
-		expect(requests[0].queryParams).toStrictEqual({ duplicates: 'false' });
+		expect(requests[0].queryParams).toStrictEqual({ duplicates: '0' });
 	});
 
 	test('attaching resources with duplicates', async () => {
@@ -51,7 +51,7 @@ describe('BelongsToMany tests', () => {
 		await belongsToManyRelation.attach([2, 5, 7], true);
 
 		const requests = server.pretender.handledRequests;
-		expect(requests[0].queryParams).toStrictEqual({ duplicates: 'true' });
+		expect(requests[0].queryParams).toStrictEqual({ duplicates: '1' });
 	});
 
 	test('attaching resources with fields', async () => {
@@ -73,7 +73,7 @@ describe('BelongsToMany tests', () => {
 		expect(attachResult.attached).toStrictEqual(['2', '5']);
 
 		const requests = server.pretender.handledRequests;
-		expect(requests[0].queryParams).toStrictEqual({ duplicates: 'false' });
+		expect(requests[0].queryParams).toStrictEqual({ duplicates: '0' });
 	});
 
 	test('attaching resources with fields with duplicates', async () => {
@@ -95,7 +95,7 @@ describe('BelongsToMany tests', () => {
 		);
 
 		const requests = server.pretender.handledRequests;
-		expect(requests[0].queryParams).toStrictEqual({ duplicates: 'true' });
+		expect(requests[0].queryParams).toStrictEqual({ duplicates: '1' });
 	});
 
 	test('detaching resources', async () => {
@@ -143,7 +143,7 @@ describe('BelongsToMany tests', () => {
 		expect(syncResult.detached).toStrictEqual([2, 5, 7]);
 
 		const requests = server.pretender.handledRequests;
-		expect(requests[0].queryParams).toStrictEqual({ detaching: 'true' });
+		expect(requests[0].queryParams).toStrictEqual({ detaching: '1' });
 	});
 
 	test('syncing resources without detaching', async () => {
@@ -155,7 +155,7 @@ describe('BelongsToMany tests', () => {
 		await belongsToManyRelation.sync([2, 5, 7], false);
 
 		const requests = server.pretender.handledRequests;
-		expect(requests[0].queryParams).toStrictEqual({ detaching: 'false' });
+		expect(requests[0].queryParams).toStrictEqual({ detaching: '0' });
 	});
 
 	test('syncing resources with fields', async () => {
@@ -179,7 +179,7 @@ describe('BelongsToMany tests', () => {
 		expect(syncResult.detached).toStrictEqual(['2', '5']);
 
 		const requests = server.pretender.handledRequests;
-		expect(requests[0].queryParams).toStrictEqual({ detaching: 'true' });
+		expect(requests[0].queryParams).toStrictEqual({ detaching: '1' });
 	});
 
 	test('syncing resources with fields without detaching', async () => {
@@ -201,7 +201,7 @@ describe('BelongsToMany tests', () => {
 		);
 
 		const requests = server.pretender.handledRequests;
-		expect(requests[0].queryParams).toStrictEqual({ detaching: 'false' });
+		expect(requests[0].queryParams).toStrictEqual({ detaching: '0' });
 	});
 
 	test('toggling resources', async () => {