Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird blur effect on the left and top of firefox #127

Open
xeros-and-ones opened this issue Nov 9, 2024 · 10 comments · May be fixed by #128
Open

weird blur effect on the left and top of firefox #127

xeros-and-ones opened this issue Nov 9, 2024 · 10 comments · May be fixed by #128
Labels
Milestone

Comments

@xeros-and-ones
Copy link

xeros-and-ones commented Nov 9, 2024

there seems to be a weird blurred parts around the left and top edges of firefox when forc blurring it
Screenshot_20241109_054025

@taj-ny
Copy link
Owner

taj-ny commented Nov 9, 2024

I thought this only affected context menus. What Firefox and GTK themes are you using? Paste your custom Firefox CSS if you have any.

@xeros-and-ones
Copy link
Author

for the gtk theme, i tried multipe but they all have it except that they vary in size and that's it.
and as for the css, here it is (bear in mind that i wrote a long time ago and haven't tried touching ever since so apologies if it's css related)

#urlbar-background,
#urlbar-container,
.urlbar-input-box {
  border: none !important;
}

#urlbar-background {
  background: #3b414b !important;
}

/* remove blue focus ring */
* {
  outline-color: transparent !important;
}

:root {
  /* remove blue focus ring */
  --toolbar-field-focus-border-color: rgb(90, 90, 90) !important;
  /* remove shadow under tab-bar */
  --tabs-navbar-shadow-size: 0 !important;
}

/*** hide "open all in tabs" ***/
.bookmark-item[type="menu"][container="true"]
  menuitem[label="Open All in Tabs"],
.bookmark-item[type="menu"][container="true"] .bookmarks-actions-menuseparator {
  display: none !important;
}

/* hide icons for bookmark folders */
#personal-bookmarks .bookmark-item[container="true"] .toolbarbutton-icon {
  display: none !important;
}

/* Coloured Bookmakark folder */
.bookmark-item[container] {
  list-style-image: url("data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZpZXdCb3g9IjAgMCAxNiAxNiIgZmlsbD0iY29udGV4dC1maWxsIiBmaWxsLW9wYWNpdHk9ImNvbnRleHQtZmlsbC1vcGFjaXR5IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPg0KICA8cGF0aCBkPSJNMTQuNSAzSDYuOTE0YS41LjUgMCAwIDEtLjM1NC0uMTQ2TDUuMTQ2IDEuNDM5QTEuNDkxIDEuNDkxIDAgMCAwIDQuMDg2IDFIMS41QTEuNSAxLjUgMCAwIDAgMCAyLjV2MTFBMS41IDEuNSAwIDAgMCAxLjUgMTVoMTNhMS41IDEuNSAwIDAgMCAxLjUtMS41di05QTEuNSAxLjUgMCAwIDAgMTQuNSAzem0uNSAxMC41YS41LjUgMCAwIDEtLjUuNWgtMTNhLjUuNSAwIDAgMS0uNS0uNVY2aDE0ek0xIDVWMi41YS41LjUgMCAwIDEgLjUtLjVoMi41ODZhLjUuNSAwIDAgMSAuMzU0LjE0NmwxLjQxNCAxLjQxNUExLjQ5MSAxLjQ5MSAwIDAgMCA2LjkxNCA0SDE0LjVhLjUuNSAwIDAgMSAuNS41VjV6IiBmaWxsPSIjYjE4NTAyIi8+DQogIDxwYXRoIGQ9Ik0xNSAxMy41YS41LjUgMCAwIDEtLjUuNWgtMTNhLjUuNSAwIDAgMS0uNS0uNVY2aDE0eiIgZmlsbC1vcGFjaXR5PSIuOCIgZmlsbD0iI2ZmZTA4MiIvPg0KICA8cGF0aCBkPSJNMSA1VjIuNWEuNS41IDAgMCAxIC41LS41aDIuNTg2YS41LjUgMCAwIDEgLjM1NC4xNDZsMS40MTQgMS40MTVBMS40OTEgMS40OTEgMCAwIDAgNi45MTQgNEgxNC41YS41LjUgMCAwIDEgLjUuNVY1eiIgZmlsbC1vcGFjaXR5PSIuNiIgZmlsbD0iI2ZmZTA4MiIvPg0KICA8cGF0aCBkPSJNMTUgMTMuNWEuNS41IDAgMCAxLS41LjVoLTEzYS41LjUgMCAwIDEtLjUtLjVWMTNoMTR6IiBmaWxsLW9wYWNpdHk9Ii41IiBmaWxsPSIjZmZlMDgyIi8+DQo8L3N2Zz4=") !important;
}

/*** main-hamburger ***/
#appMenu-fxa-status,
/* Sign in to Sync / Open Sync preferences / Reconnect to Sync */
#appMenu-mainView toolbarseparator.sync-ui-item,
/**** Separator ****/
#appMenu-protection-report-button,
/* Privacy Protections */
#appMenu-tp-separator,
/**** Separator ****/
#appMenu-zoom-controls,
/* Zoom */
#appMenu-zoom-controls+toolbarseparator,
/**** Separator ****/
#appMenu-edit-controls,
/* Edit */
#appMenu-edit-controls+toolbarseparator,
/**** Separator ****/
#appMenu-library-button,
/* Library */
#appMenu-customize-button+toolbarseparator,
/**** Separator ****/
#appMenu-open-file-button,
/* Open File… */
#appMenu-save-file-button,
/* Save Page As… */
#appMenu-print-button,
/* Print… */
#appMenu-print-button+toolbarseparator,
/**** Separator ****/
#appMenu-find-button,
/* Find in This Page… */
#appMenu-whatsnew-button,
/* What's New */
#appMenu-help-button+toolbarseparator,
/**** Separator ****/
#leave_this_dummy_here {
  display: none !important;
}

/* Show Tab Close buttons only when hovered */
.tabbrowser-tab:not([pinned]):hover .tab-close-button {
  display: block !important;
}

#tabbrowser-tabs {
  --uc-tabs-scrollbutton-border: 0px;
  --proton-tab-block-margin: 0px;
  --tab-block-margin: 2px;
  --uc-tab-line-color: rgb(10, 132, 255);
}

.tabbrowser-tab {
  padding-inline: 0px !important;
  /* By default, proton tabs have 2px + 2px = 4px space between them */
}

#TabsToolbar {
  --toolbarbutton-inner-padding: 6px !important;
}

#scrollbutton-up,
#scrollbutton-down {
  border-block-width: var(--uc-tabs-scrollbutton-border, 0px) !important;
}

/*-------------LIBRARY-------------*/
@-moz-document url("chrome://browser/content/places/places.xhtml")
{
  :root {
    --organizer-border-color: none !important;
  }

  treechildren::-moz-tree-row(selected, current) {
    border-color: none !important;
  }

  treechildren::-moz-tree-row(selected, current, focus) {
    border-color: none !important;
  }
}

/*--------bookmarking page popup--------*/
#editBookmarkPanelBottomContent,
#editBMPanel_tagsRow,
#editBMPanel_tagsSelectorRow #editBMPanel_keywordRow {
  display: none !important;
}

/*** Change right-click tab -> reload tab to be first context menu entry (for both single tab and multiple tab selections) ***/
#tabContextMenu #context_reloadTab,
#tabContextMenu #context_reloadSelectedTabs {
  -moz-box-ordinal-group: 0 !important;
}

#tabbrowser-tabs {
  --user-tab-rounding: 0px;
}

.tab-background {
  border-radius: var(--user-tab-rounding) var(--user-tab-rounding) 0px 0px !important;
  /* Connected */
  margin-block: 1px 0 !important;
  /* Connected */
}

#scrollbutton-up,
#scrollbutton-down {
  /* 6/10/2021 */
  border-top-width: 1px !important;
  border-bottom-width: 0 !important;
}

/* 1/16/2022 Tone down the Fx96 tab border with add-on themes in certain fallback situations */
.tab-background:is([selected], [multiselected]):-moz-lwtheme {
  --lwt-tabs-border-color: rgba(0, 0, 0, 0.5) !important;
  border-bottom-color: transparent !important;
}

[brighttext="true"]
  .tab-background:is([selected], [multiselected]):-moz-lwtheme {
  --lwt-tabs-border-color: rgba(255, 255, 255, 0.5) !important;
  border-bottom-color: transparent !important;
}

/* Container color bar visibility */
.tabbrowser-tab[usercontextid]
  > .tab-stack
  > .tab-background
  > .tab-context-line {
  margin: 0px max(calc(var(--user-tab-rounding) - 3px), 0px) !important;
}

/* [Connected Tabs] Set a max height based on min-height plus margin-block: 1px 0 */
#TabsToolbar,
#TabsToolbar > hbox,
#TabsToolbar-customization-target,
#tabbrowser-arrowscrollbox {
  max-height: calc(var(--tab-min-height) + 1px) !important;
}

/* [Connected Tabs] Adjust padding around icons on buttons to avoid crushed images */
#TabsToolbar-customization-target toolbarbutton > .toolbarbutton-icon,
#TabsToolbar-customization-target .toolbarbutton-text,
#TabsToolbar-customization-target .toolbarbutton-badge-stack,
#scrollbutton-up,
#scrollbutton-down {
  padding-top: 5px !important;
  padding-bottom: 4px !important;
}

/*** Tighten up drop-down/context/popup menu spacing (8 Sep 2021) ***/

menupopup:not(.in-menulist) > menuitem,
menupopup:not(.in-menulist) > menu {
  padding-block: 2px !important;
  /* reduce to 3px, 2px, 1px or 0px as needed */
  min-height: unset !important;
  /* v92.0 - for padding below 4px */
}

:root {
  --arrowpanel-menuitem-padding: 1px 5px !important;
  /*--arrowpanel-border-radius: 0px !important; */
  --panel-subview-body-padding: 2px 0px !important;
  --arrowpanel-padding: 1.3em !important;
  --arrowpanel-menuitem-margin: 0 0px !important;
}

/* show audio icon as a separate icon in compact mode */
.tab-icon-stack:is([muted], [soundplaying], [activemedia-blocked]) {
  grid-template-areas: "a s";
}

.tab-icon-overlay:is([muted], [soundplaying], [activemedia-blocked]) {
  grid-area: s;
}

.tab-icon-overlay,
.tab-icon-image {
  opacity: 1 !important;
}

.tab-icon-overlay {
  padding: 0 !important;
}

.tab-icon-overlay:hover {
  background: none !important;
}

/* remove space pre tabs */
#TabsToolbar *[type="pre-tabs"] {
  display: none !important;
}

@taj-ny
Copy link
Owner

taj-ny commented Nov 9, 2024

for the gtk theme, i tried multipe but they all have it except that they vary in size and that's it.

Which theme exactly did you run into this issue with? I tried a few, but couldn't reproduce this.

Are you on Wayland or X11?

@xeros-and-ones
Copy link
Author

i'm on x11, i tried breeze and layan-dark-gtk.
here it is with breeze
Screenshot_20241109_065245
and here it is with layan-dark-gtk
Screenshot_20241109_065216

@taj-ny
Copy link
Owner

taj-ny commented Nov 9, 2024

Try the blur/force-blur/fix-x11-csd branch, it should be fixed. The blur region for context menus may still be too large, as that's a different issue.

@xeros-and-ones
Copy link
Author

sorry for the delayed reply, but i had to test a different environment, i was using endeavourOS when i issued the bug but i was gonna reinstall nixOS anyways so i did and installed the plugin using the repo's flake and it's working perfectly fine.
so i'm guessing it's endeavourOS related or something

@xeros-and-ones
Copy link
Author

welp, spoke too soon, it's somehow back

@taj-ny
Copy link
Owner

taj-ny commented Nov 10, 2024

Does it occur on the blur/force-blur/fix-x11-csd branch?

@xeros-and-ones
Copy link
Author

i've installed using the flake so let me try the branch

@xeros-and-ones
Copy link
Author

i've moved from the flake master branch to the blur/force-blur/fix-x11-csd branch and it seems to be working correctly, hopefully

@taj-ny taj-ny added this to the v1.4.0 milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants