Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension crashes if texture size is given as array #16

Open
tchayen opened this issue Jun 12, 2023 · 0 comments
Open

Extension crashes if texture size is given as array #16

tchayen opened this issue Jun 12, 2023 · 0 comments

Comments

@tchayen
Copy link

tchayen commented Jun 12, 2023

Hi!

I noticed that extension crashes on my code which uses array to provide texture size.

I checked code from the stacktrace and noticed that there's object destructuring used to retrieve width and height. Once I changed my code to use object syntax ({ width: X, height: Y, depthOrArrayLayers: N } instead of [X, Y, N]) it stopped crashing.

So my suggestion is to add support for both, given that array syntax is supported by browsers and correct according to TypeScript types.

I can also open PR to change it if it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant