Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize code and don't use require_relative in exec_annotation #14

Open
duboism opened this issue Jun 4, 2020 · 1 comment
Open

Comments

@duboism
Copy link

duboism commented Jun 4, 2020

The current organization of the code makes the code a bit hard to install because the main script (exec_annotation) use require_relative to find the lib/ directory (therefore the lib/ directory and exec_annotation must be in the same directory).

I don't know the conventions in the Ruby community but if I trust this book, the main script (exec_annotation) :

  • should be in the bin/ directory
  • could perform some magic (modification of $LOAD_PATH) to find the lib/ directory (I'm not really fond of this idea; I would rather rely on the RUBYLIB variable and modify LOAD_PATH if this fails)
  • use require 'lib/kofam_scan' instead of require_relative 'lib/kofam_scan'

This would simplify installation in our environment for example and probably in most environments too.

@duboism
Copy link
Author

duboism commented Jan 15, 2021

Any thoughts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant