You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That seems like a fair bit of code - no wonder you skipped over it before! Based on your knowledge of the code, is it all fairly mechanical porting work, or is it going to be hard work?
(Do you have any other ideas for dynamically adding new entries, that don't require recompiling, then reloading, all the dictionary files?)
The text was updated successfully, but these errors were encountered:
I found the TODO for user dictionaries:
https://github.com/takuyaa/kuromoji.js/blob/master/src/Tokenizer.js#L110
But, comparing to the atilika version of kuromoji, I think the user dictionary code actually needs to go here:
https://github.com/takuyaa/kuromoji.js/blob/master/src/viterbi/ViterbiBuilder.js#L96
Ref: https://github.com/atilika/kuromoji/blob/master/kuromoji-core/src/main/java/com/atilika/kuromoji/viterbi/ViterbiBuilder.java#L101
https://github.com/atilika/kuromoji/blob/master/kuromoji-core/src/main/java/com/atilika/kuromoji/viterbi/ViterbiBuilder.java#L176
https://github.com/atilika/kuromoji/blob/d0700ab6dd489aaf0fcb1e4e78ce2f682be9f255/kuromoji-core/src/main/java/com/atilika/kuromoji/dict/UserDictionary.java#L72
That seems like a fair bit of code - no wonder you skipped over it before! Based on your knowledge of the code, is it all fairly mechanical porting work, or is it going to be hard work?
(Do you have any other ideas for dynamically adding new entries, that don't require recompiling, then reloading, all the dictionary files?)
The text was updated successfully, but these errors were encountered: