You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for enumerating these. Some comments on some of these:
7. This is just for defining the is_regularized mask, which is there because it uses site_index_map. Can move to new function.
12. Wrong link?
13. This can be done after we set up the workflow for testing each optimization step individually to find if the second optimization step is helpful or not.
14. res -> result. Can change to that instead
22. I think I meant to say "m_phase" here. Def need to write a real docstring for that one
Some improvements to comments, etc.
n
to more descriptive variable name: https://github.com/talmolab/stac-mjx/blob/main/stac_mjx/controller.py#L62C8-L64C10run_kinematics
: https://github.com/talmolab/stac-mjx/blob/main/stac_mjx/operations.py#L12m_opt
tomarker_optimization
: https://github.com/talmolab/stac-mjx/blob/main/stac_mjx/stac_base.py#L186sample_frame_indices
: https://github.com/talmolab/stac-mjx/blob/main/stac_mjx/compute_stac.py#L138site_idxs
arg to doc string:stac-mjx/stac_mjx/operations.py
Line 43 in f022418
stac-mjx/stac_mjx/stac_base.py
Line 37 in f022418
stac-mjx/stac_mjx/compute_stac.py
Line 161 in f022418
The text was updated successfully, but these errors were encountered: