Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatching events per page #40

Closed
danieldanielecki opened this issue Aug 28, 2022 · 6 comments
Closed

Dispatching events per page #40

danieldanielecki opened this issue Aug 28, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@danieldanielecki
Copy link
Contributor

Events could've been dispatched per each API's page for performance improvements.

A similar technique has been incorporated in dispatching Ticketmaster events per country: 57a01df. In that case, there are more "refreshes" on the maps while dispatching the events, and those are shown gradually, and the user isn't left with (more) empty maps. For the Ticketmaster events, it was about Europe being completely empty till all events were loaded from APIs. Instead, the maps refreshes per each country-loaded events.

@danieldanielecki danieldanielecki added the enhancement New feature or request label Aug 28, 2022
@danieldanielecki
Copy link
Contributor Author

Use https://github.com/bamlab/react-native-flipper-performance-monitor for monitoring performance and https://github.com/jhen0409/react-native-debugger for debugging while working on this story

@danieldanielecki
Copy link
Contributor Author

Include also https://rnfirebase.io/perf/axios-integration while working on this story.

@danieldanielecki
Copy link
Contributor Author

It'll be not done, because rendering is expensive, with splitting actions to separated files in 55e8f93 we gained lots of performance and it was the bottleneck.

@danieldanielecki
Copy link
Contributor Author

Last piece of splitting actions to separated files improvement in ad566ad has been done.

@danieldanielecki
Copy link
Contributor Author

Include also https://rnfirebase.io/perf/axios-integration while working on this story.

We don't need to add any extra interceptors because it's just for creating extra metric attributes.
We're good with the default ones, and we can see everything we need: duration, HTTP response codes, network, CPU, etc. in Firebase's Perfomance tab.

@danieldanielecki
Copy link
Contributor Author

Regarding debugging, even with jhen0409/react-native-debugger#755 (comment) I had a blank screen, but once handling Hermes will be done it can be useful debugger, on top of already existing cmd+D developer tools. As of now, it looks like anything related to debugging in Chrome doesn't work.

Regarding https://github.com/bamlab/react-native-flipper-performance-monitor, little problem was clarified in bamlab/react-native-flipper-performance-monitor#84 (comment), but it wasn't possible to run it.

With those comments, there's nothing more to take a look in this issue. Maybe at some point, it could be helpful to debug, but for now changes related to 55e8f93 can help with performance improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant