You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So instead of putting everything into one file, I would have splitted it into multiple smaller files (EditEventScreenStyles.ts, LoadingView.ts, InternetConnectionErrorView.ts, EditEventScreen.ts, reportError, EditEventHeaderButtons, userLocationHandlerCallback) and renamed it to the EditEventView.ts.
The text was updated successfully, but these errors were encountered:
Actions have split in 55e8f93 which significantly improved performance. Now, each HTTP request is independent and speeds up the load of markers on the map.
Take a look into
store
, whereactions
anddispatchers
are in a single file.However, there's also feedback regarding
EditEventScreen
on https://github.com/AidOnline01/review-daniel/blob/main/1-huge-files.md. Similarly, other files could split up.Example:
About the issue
There is a violation of Single Responsibility principle, which creates huge files and reduces maintability/testability/reusability of codebase.
Example
Example from the code
EditEventScreen
How it could have been done?
Changes
So instead of putting everything into one file, I would have splitted it into multiple smaller files (
EditEventScreenStyles.ts, LoadingView.ts, InternetConnectionErrorView.ts, EditEventScreen.ts, reportError, EditEventHeaderButtons, userLocationHandlerCallback
) and renamed it to theEditEventView.ts
.The text was updated successfully, but these errors were encountered: