Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC request for wallet address seems wrong? #6641

Open
leet4tari opened this issue Oct 18, 2024 · 3 comments
Open

GRPC request for wallet address seems wrong? #6641

leet4tari opened this issue Oct 18, 2024 · 3 comments

Comments

@leet4tari
Copy link
Contributor

Using a grpc command line client for testing, doing a request for the wallet address returns the following

{
 "interactive_address": "AgMul6+IgTQZ46vxd6jjYns8zp9+3vukUaaepU6qF8MLMoZt3gjutTS78qgnmXFd/EClOMSh1JqJk5X6l6aVx8ZDBA==",
 "one_sided_address": "AgEul6+IgTQZ46vxd6jjYns8zp9+3vukUaaepU6qF8MLMoZt3gjutTS78qgnmXFd/EClOMSh1JqJk5X6l6aVx8ZDKw=="
}

where the wallet address should be

Tari Address interactive:   3457UQxqpvSJnSyGFkgHkJgJB6r7BM3L4MM5nLL6jZpok3Pk8mtCnHGQi2HeRjHcUS7BwEPGcoRvBB43Y2einGhX8Mq                                            
Tari Address one-sided:     3257UQxqpvSJnSyGFkgHkJgJB6r7BM3L4MM5nLL6jZpok3Pk8mtCnHGQi2HeRjHcUS7BwEPGcoRvBB43Y2einGhX8NW

Tried base64 and base58 decoding, neither decoders return a similar address.

Could I get some info on how to get this to work or get what I am looking for?

@leet4tari leet4tari changed the title GRPC request for GRPC request for wallet address seems wrong? Oct 18, 2024
@SWvheerden
Copy link
Collaborator

What you are showing here is not possible, the client you are using is somehow encoding the results.
https://github.com/tari-project/tari/blob/c42586517a06382106a7fb20939e0a9cbe2e5789/applications/minotari_app_grpc/proto/wallet.proto#L91C1-L92C1

those should be bytes, not a string.

@SWvheerden
Copy link
Collaborator

But it might be worth the effort to make this a string and encode it to base58. Is going to be a breaking change

@leet4tari
Copy link
Contributor Author

How about getAddressString which would not break the current interface?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants